SentinelOne V2 - Modified Command Add-hash-to-blocklist, remove-hash-from-blocklist, and get-agent-request #40569
Conversation
Modified following commands 1. sentinelone-add-hash-to-blocklist command to support different scope (site/account/group/global) 2. sentinelone-remove-hash-from-blocklist command to support different scope (site/account/group/global)
Modified sentinelone-get-agent command to support multiple agent ids
|
|
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/purushottamk-s1_master
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @merit-maita will know the proposed changes are ready to be reviewed. |
|
Hi @purushottamk-s1, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
purushottamk-s1
changed the title
content-bot
added
Community
Contribution Form Filled
Added new Release Note and updated pack_metadata.json
| site_ids = site_ids or "" | ||
| group_ids = group_ids or "" | ||
| account_ids = account_ids or "" |
There was a problem hiding this comment.
you can change the default value for them in the function to be "" instead of None, then there won't be any need for these lines
There was a problem hiding this comment.
Thanks for suggestion did the changes accordingly
| name: sha1 | ||
| required: true |
There was a problem hiding this comment.
why did you set it to be required? it will break the previous functionality
| - description: Comma-separated string of site IDs to scope the blocklist. | ||
| name: site_ids |
There was a problem hiding this comment.
its the same arg that was deleted with the name "block_site_ids". if so, please continue using the previous to avoid breaking changes
There was a problem hiding this comment.
Thanks for pointing that out!
I’ve reverted to the previous logic — now using block_site_ids again. If block_site_ids is provided and site_ids comes from the command arguments, both are combined to scope the blocklist.
merit-maita
added
the
pending-contributor
|
Hi @merit-maita Regarding the contribution form, I have already filled it out. For your reference, I’ve also attached a screenshot confirming the submission. Please let me know if there’s anything else needed. |
Main PR commit comments resolved
|
@purushottamk-s1 regarding the contribution form i'll handle it, on the other side, to move forward with the pr, there're some unit tests failing, please handle them. |
merit-maita
added
the
ready-for-instance-test
|
For the Reviewer: Trigger build request has been accepted for this contribution PR. |
|
For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/4186524 |
content-bot
removed
the
ready-for-instance-test
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
Main PR commit Unit test failure comment resolved
Hi @merit-maita, Thanks for the update. I have checked the failing unit tests, made the necessary changes, and updated the PR accordingly. Please let me know if there’s anything else needed to move forward. |
Updated README.md file for block_site_ids
|
@purushottamk-s1 greate, you're pre-commit is green now, for the last step, can you record a demo video of the new commands please? |
|
Hi @merit-maita, If you could share your email address with me, I’ll be happy to give you access to the video via Drive. Let me know what works best for you. Thanks again! |
Hey @purushottamk-s1 |
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Modified Command Add-hash-to-blocklist and remove-hash-from-blocklist to support multiple scope.
Modified command get-agent-request to support multiple agent ids
Must have