Updated AV2310 for local functions#155
Closed
bkoelman wants to merge 1 commit into
Closed
Conversation
16 tasks
|
|
||
| ### <a name="av2310"></a> Avoid inline comments (AV2310)  | ||
| If you feel the need to explain a block of code using a comment, consider replacing that block with a method with a clear name. | ||
| If you feel the need to explain a block of code using a comment, consider replacing that block with a method or local function with a clear name. |
Owner
There was a problem hiding this comment.
I'm not sure about this one. If the code becomes that much unreadable, a local function will not really help focusing on the current body. In that case, I would prefer to have a separate method or to properly encapsulate a concept that is now represented by primitive types. See also https://www.continuousimprover.com/2015/10/9-simple-practices-for-writing-better.html
Contributor
Author
There was a problem hiding this comment.
Makes sense. Let's discard this PR then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.