Skip to content

Conversation

@tristan-f-r
Copy link

@tristan-f-r tristan-f-r commented Feb 3, 2023

adds a devcontainer with Deno (for www) and Rust (for the repo itself) support.

(If a contributor agrees) I do also think that the perf tools should be added as well (as mentioned in README), but for now it's a bare container.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the useful configuration!
Could you add .devcontainer directory to the format target in tools/format.ts, so deno fmt will be applied to devcontainer.json?
Like this:

const p3 = await Deno.run({
  cmd: [
    "deno",
    "fmt",
    ...checkArgs,
    "tools",
    "benchmarks/benchmarks.ts",
    "www/pages",
    "docs/rules",
    "README.md",
+   ".devcontainer",
  ],
  stdin: "null",
}).status();

Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also don't remember to run the formatter so the CI passes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants