Skip to content

fix(prefer-primordials): allow private identifier in in expression #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0f-0b wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(prefer-primordials): allow private identifier in in expression #1308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 34 additions & 14 deletions src/rules/prefer_primordials.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,20 +708,24 @@ impl Handler for PreferPrimordialsHandler {
fn bin_expr(&mut self, bin_expr: &ast_view::BinExpr, ctx: &mut Context) {
use ast_view::BinaryOp;

if matches!(bin_expr.op(), BinaryOp::InstanceOf) {
ctx.add_diagnostic_with_hint(
bin_expr.range(),
CODE,
PreferPrimordialsMessage::InstanceOf,
PreferPrimordialsHint::InstanceOf,
);
} else if matches!(bin_expr.op(), BinaryOp::In) {
ctx.add_diagnostic_with_hint(
bin_expr.range(),
CODE,
PreferPrimordialsMessage::In,
PreferPrimordialsHint::In,
);
match bin_expr.op() {
BinaryOp::InstanceOf => {
ctx.add_diagnostic_with_hint(
bin_expr.range(),
CODE,
PreferPrimordialsMessage::InstanceOf,
PreferPrimordialsHint::InstanceOf,
);
}
BinaryOp::In if !bin_expr.left.is::<ast_view::PrivateName>() => {
ctx.add_diagnostic_with_hint(
bin_expr.range(),
CODE,
PreferPrimordialsMessage::In,
PreferPrimordialsHint::In,
);
}
_ => {}
}
}
}
Expand Down Expand Up @@ -908,6 +912,15 @@ function foo(): Array<any> {}
r#"
type p = Promise<void>;
"#,
r#"
class A {
#brand;

static is(obj) {
return #brand in obj;
}
}
"#,
};
}

Expand Down Expand Up @@ -1289,6 +1302,13 @@ new DataView(new ArrayBuffer(10)).byteOffset;
hint: PreferPrimordialsHint::In,
},
],
r#"a in A"#: [
{
col: 0,
message: PreferPrimordialsMessage::In,
hint: PreferPrimordialsHint::In,
},
],
r#"a instanceof A"#: [
{
col: 0,
Expand Down