switch to Deno.Command and bump the minimum supported Deno version to 1.28.3(#154)

Author: magurotuna

.github/workflows/ci.yml

@@ -24,7 +24,7 @@ jobs:
       - name: Setup Deno
         uses: denoland/setup-deno@v1
         with:
-          deno-version: ${{ matrix.deno == 'old' && '1.20.1' || (matrix.deno == 'stable' && '1.x' || matrix.deno) }}
+          deno-version: ${{ matrix.deno == 'old' && '1.28.3' || (matrix.deno == 'stable' && '1.x' || matrix.deno) }}
 
       - run: deno --version
 

src/subcommands/upgrade.ts

@@ -60,10 +60,8 @@ export default async function (rawArgs: Record<string, any>): Promise<void> {
     console.log("You're using the latest version.");
     Deno.exit();
   } else {
-    // deno-lint-ignore no-deprecated-deno-api
-    const process = Deno.run({
-      cmd: [
-        Deno.execPath(),
+    const process = new Deno.Command(Deno.execPath(), {
+      args: [
         "install",
         "--allow-read",
         "--allow-write",
@@ -74,8 +72,8 @@ export default async function (rawArgs: Record<string, any>): Promise<void> {
         "-f",
         `https://deno.land/x/deploy@${version ? version : latest}/deployctl.ts`,
       ],
-    });
-    await process.status();
+    }).spawn();
+    await process.status;
   }
 }
 

src/version.ts

@@ -1,3 +1,3 @@
 export const VERSION = "1.6.0";
 
-export const MINIMUM_DENO_VERSION = "1.20.0";
+export const MINIMUM_DENO_VERSION = "1.28.3";

tests/utils.ts

@@ -15,7 +15,7 @@ export function deployctl(
     env: true,
     run: true,
   },
-): Deno.Process {
+): Deno.ChildProcess {
   const deno = [
     Deno.execPath(),
     "run",
@@ -34,13 +34,12 @@ export function deployctl(
     ? ["bash", "-c", [...deno, ...args].join(" ")]
     : [...deno, ...args];
 
-  // deno-lint-ignore no-deprecated-deno-api
-  return Deno.run({
-    cmd,
+  return new Deno.Command(cmd[0], {
+    args: cmd.slice(1),
     stdin: "null",
     stdout: "piped",
     stderr: "piped",
-  });
+  }).spawn();
 }
 
 export interface TestOptions {
@@ -51,26 +50,21 @@ export interface TestOptions {
 
 export function test(
   opts: TestOptions,
-  fn: (proc: Deno.Process) => void | Promise<void>,
+  fn: (proc: Deno.ChildProcess) => void | Promise<void>,
 ) {
   const name = opts.name ?? ["deployctl", ...opts.args].join(" ");
   Deno.test(name, async () => {
     const proc = deployctl(opts.args, opts.permissions);
-    try {
-      await fn(proc);
-    } finally {
-      proc.close();
-    }
+    await fn(proc);
   });
 }
 
 export async function output(
-  proc: Deno.Process,
-): Promise<[string, string, Deno.ProcessStatus]> {
-  const [status, stdout, stderr] = await Promise.all([
-    proc.status(),
+  proc: Deno.ChildProcess,
+): Promise<[string, string, Deno.CommandStatus]> {
+  const [status, { stdout, stderr }] = await Promise.all([
+    proc.status,
     proc.output(),
-    proc.stderrOutput(),
   ]);
   return [
     new TextDecoder().decode(stdout),