Skip to content

installsAfter looks for an exact match even when version is missing. #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brendandburns opened this issue Dec 23, 2022 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@brendandburns
Copy link

brendandburns commented Dec 23, 2022

I have read through #163 and though it is related, I think this is a different issue.

It appears that the installAfter feature is looking for an exact string match rather than a prefix.

I want to be able to say:

    "installsAfter": [
        "ghcr.io/devcontainers/features/common-utils"
    ]

and have that match:

   "features": {
       "ghcr.io/devcontainers/features/common-utils:1.0.0"
   }

I suspect the problem is here:

const first = nodesById.get(firstId);

Where there is a Map.get(featureId) call which won't match the feature with the semantic version above.

@brendandburns brendandburns changed the title installAfter looks for an exact match even when version is missing. installsAfter looks for an exact match even when version is missing. Dec 23, 2022
@samruddhikhandale
Copy link
Member

samruddhikhandale commented Dec 28, 2022

Hi 👋

Thanks for reporting.

I already have a PR out which fixes this bug --> https://github.com/devcontainers/cli/pull/335/files#r1055939808

@samruddhikhandale
Copy link
Member

Released the fix with v0.27.0 🚀
Feel free to re-open this issue if the bug resurfaces, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants