Skip to content

Add DevfileRegistry CRD field for setting the ingress class #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
Tracked by #1274
michael-valdron opened this issue Feb 1, 2024 · 1 comment · Fixed by devfile/registry-operator#79
Closed
3 tasks
Tracked by #1274
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure

Comments

@michael-valdron
Copy link
Member

Which area/kind this issue is related to?

/area registry

Issue Description

The registry operator is missing a field to set the ingress class name https://github.com/devfile/registry-operator/blob/f55ab8e7c8061934547c7d55bd67d81d509a8752/api/v1alpha1/devfileregistry_types.go#L117, which is what the helm chart has: https://github.com/devfile/registry-support/blob/f66264f22310c3c93bf0c77db5f4cd4b560aba5e/deploy/chart/devfile-registry/values.yaml#L18

Parent Epic: #1274

Acceptance Criteria

  • Implement DevfileRegistry.K8s.IngressClass field
  • Create test case to set DevfileRegistry.K8s.IngressClass field
  • Run integration tests to verify changes
@thepetk thepetk self-assigned this Feb 6, 2024
@thepetk thepetk moved this to Refinement in Devfile Project Feb 6, 2024
@thepetk thepetk added the area/registry Devfile registry for stacks and infrastructure label Feb 6, 2024
@thepetk thepetk moved this from Refinement to To Do 📝 in Devfile Project Feb 7, 2024
@thepetk
Copy link
Contributor

thepetk commented Feb 12, 2024

As discussed this item will not be covered during this sprint so it will be moved to the next one (2257)

@thepetk thepetk moved this from To Do 📝 to In Progress 🚧 in Devfile Project Mar 1, 2024
@thepetk thepetk moved this from In Progress 🚧 to In Review 👀 in Devfile Project Mar 4, 2024
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in Devfile Project Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

2 participants