Skip to content

Library needs to be updated due to attriubtes change #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks
yangcao77 opened this issue Nov 20, 2020 · 1 comment
Closed
3 tasks

Library needs to be updated due to attriubtes change #228

yangcao77 opened this issue Nov 20, 2020 · 1 comment
Assignees
@maysunfaisal
Labels
area/library Common devfile library for interacting with devfiles

Comments

@yangcao77
Copy link
Contributor

After the attributes change in devfile schema & struct merged (#214) in api repo, the common library also requires change due to the attriubtes type difference.

The issue involves:

  • Modify existing parser code

  • Test properly to make sure no issues with the new attributes type and additional attribute field in metadata

  • Add more unit tests if needed
@yangcao77 yangcao77 self-assigned this Nov 20, 2020
@yangcao77 yangcao77 added the area/library Common devfile library for interacting with devfiles label Nov 20, 2020
@yangcao77
Copy link
Contributor Author

resolved in devfile/library#46

@yangcao77 yangcao77 assigned maysunfaisal and unassigned yangcao77 Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maysunfaisal maysunfaisal

Labels
area/library Common devfile library for interacting with devfiles
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yangcao77 @maysunfaisal