Skip to content

Parser api inconsistencies commands v others #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mmulholla opened this issue Dec 1, 2020 · 1 comment
Closed

Parser api inconsistencies commands v others #246

mmulholla opened this issue Dec 1, 2020 · 1 comment
Assignees
@maysunfaisal

Comments

@mmulholla
Copy link
Contributor

mmulholla commented Dec 1, 2020 •
edited
Loading

The parser API treats commands differently from other objects:

GetCommands() map[string]v1.Command
AddCommands(commands ...v1.Command) error

compared to, for example,

GetComponents() []v1.Component
AddComponents(components []v1.Component) error

would be better if commands was:

GetCommands() []v1.Command
AddCommands(commands []v1.Command) error
@yangcao77
Copy link
Contributor

fixed in devfile/library#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maysunfaisal maysunfaisal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yangcao77 @maysunfaisal @mmulholla