fixup! Propagate DevWorkspace .spec.started status to an annotation on routings

Author: amisevsk

controllers/workspace/devworkspace_controller.go

@@ -417,7 +417,7 @@ func (r *DevWorkspaceReconciler) doStop(workspace *dw.DevWorkspace, logger logr.
 		return false, err
 	}
 
-	// Update DevWorkspaceRouting to have .spec.started=false
+	// Update DevWorkspaceRouting to have `devworkspace-started` annotation "false"
 	routing := &v1alpha1.DevWorkspaceRouting{}
 	routingRef := types.NamespacedName{
 		Name:      common.DevWorkspaceRoutingName(workspace.Status.DevWorkspaceId),

pkg/provision/workspace/routing.go

@@ -154,7 +154,7 @@ func getSpecRouting(
 	if val, ok := workspace.Annotations[constants.DevWorkspaceRestrictedAccessAnnotation]; ok {
 		annotations = maputils.Append(annotations, constants.DevWorkspaceRestrictedAccessAnnotation, val)
 	}
-	annotations[constants.DevWorkspaceStartedStatusAnnotation] = "true"
+	annotations = maputils.Append(annotations, constants.DevWorkspaceStartedStatusAnnotation, "true")
 
 	// copy the annotations for the specific routingClass from the workspace object to the routing
 	expectedAnnotationPrefix := workspace.Spec.RoutingClass + constants.RoutingAnnotationInfix