Add test case to ensure clusterHostSuffix isn't erased on config update

Signed-off-by: Angel Misevski <[email protected]>

Author: amisevsk

pkg/config/sync_test.go

@@ -140,6 +140,7 @@ func TestDetectsOpenShiftRouteSuffix(t *testing.T) {
 }
 
 func TestSyncConfigFromIgnoresOtherConfigInOtherNamespaces(t *testing.T) {
+	setupForTest(t)
 	internalConfig = DefaultConfig.DeepCopy()
 	config := buildConfig(&v1alpha1.OperatorConfiguration{
 		Workspace: &v1alpha1.WorkspaceConfig{
@@ -152,6 +153,7 @@ func TestSyncConfigFromIgnoresOtherConfigInOtherNamespaces(t *testing.T) {
 }
 
 func TestSyncConfigFromIgnoresOtherConfigWithOtherName(t *testing.T) {
+	setupForTest(t)
 	internalConfig = DefaultConfig.DeepCopy()
 	config := buildConfig(&v1alpha1.OperatorConfiguration{
 		Workspace: &v1alpha1.WorkspaceConfig{
@@ -164,6 +166,7 @@ func TestSyncConfigFromIgnoresOtherConfigWithOtherName(t *testing.T) {
 }
 
 func TestSyncConfigDoesNotChangeDefaults(t *testing.T) {
+	setupForTest(t)
 	oldDefaultConfig := DefaultConfig.DeepCopy()
 	internalConfig = DefaultConfig.DeepCopy()
 	config := buildConfig(&v1alpha1.OperatorConfiguration{
@@ -181,6 +184,38 @@ func TestSyncConfigDoesNotChangeDefaults(t *testing.T) {
 	assert.Equal(t, DefaultConfig, oldDefaultConfig)
 }
 
+func TestSyncConfigDoesNotEraseClusterRoutingSuffix(t *testing.T) {
+	setupForTest(t)
+	infrastructure.InitializeForTesting(infrastructure.OpenShiftv4)
+	testRoute := &routev1.Route{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      openShiftTestRouteName,
+			Namespace: testNamespace,
+		},
+		Spec: routev1.RouteSpec{
+			Host: fmt.Sprintf("%s-%s.test-host", openShiftTestRouteName, testNamespace),
+		},
+	}
+	client := fake.NewClientBuilder().WithScheme(scheme).WithObjects(testRoute).Build()
+	err := SetupControllerConfig(client)
+	if !assert.NoError(t, err, "Should not return error") {
+		return
+	}
+	assert.Equal(t, "test-host", Routing.ClusterHostSuffix, "Should get clusterHostSuffix from route on OpenShift")
+	syncConfigFrom(buildConfig(&v1alpha1.OperatorConfiguration{
+		Routing: &v1alpha1.RoutingConfig{
+			DefaultRoutingClass: "test-routingClass",
+		},
+		Workspace: &v1alpha1.WorkspaceConfig{
+			ImagePullPolicy: "IfNotPresent",
+		},
+	}))
+	if !assert.NoError(t, err, "Should not return error") {
+		return
+	}
+	assert.Equal(t, "test-host", Routing.ClusterHostSuffix, "clusterHostSuffix should persist after an update")
+}
+
 func TestMergeConfigLooksAtAllFields(t *testing.T) {
 	f := fuzz.New().NilChance(0)
 	expectedConfig := &v1alpha1.OperatorConfiguration{}