Skip to content

Remove configmap from operator #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amisevsk opened this issue Nov 2, 2020 · 2 comments · Fixed by #598
Closed

Remove configmap from operator #191

amisevsk opened this issue Nov 2, 2020 · 2 comments · Fixed by #598

Comments

@amisevsk
Copy link
Collaborator

amisevsk commented Nov 2, 2020

Is your enhancement related to a problem? Please describe.

Currently, the devworkspace operator relies on a configmap to define a few options (default routingClass, etc.). However, operators as managed by OLM don't come with configmaps, and instead we create a configmap on cluster during startup as a way of manually configuring the operator after the fact.

Describe the solution you'd like

We should remove configmap functionality as its generally not used for operators. Instead configuration should be defined in a standard way, e.g. by OLM descriptors

Additional context

This issue was created for a TODO added in PR #187

@davidfestal
Copy link
Collaborator

We should remove configmap functionality as its generally not used for operators. Instead configuration should be defined in a standard way, e.g. by OLM descriptors

I'm not sure I understand your point here. Aren't OLM descriptors used to specify the UI for presenting / changing Custom Resources in the OperatorHub console. I don't see how you plan to use them to set controller settings...

@amisevsk
Copy link
Collaborator Author

amisevsk commented Nov 4, 2020

Aren't OLM descriptors used to specify the UI for presenting / changing Custom Resources in the OperatorHub console. I don't see how you plan to use them to set controller settings...

Maybe I misinterpreted the purpose of OLM descriptors, but even so, configuring an operator via a configmap does not seem to be a standard flow (happy to be wrong, though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants