Skip to content

Make unrecoverable events in controller configurable #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amisevsk opened this issue Aug 11, 2021 · 0 comments · Fixed by #598
Closed

Make unrecoverable events in controller configurable #550

amisevsk opened this issue Aug 11, 2021 · 0 comments · Fixed by #598
Assignees
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Milestone

Comments

@amisevsk
Copy link
Collaborator

Description

As of PR #549, there is a list of events that cause the controller to mark DevWorkspaces as failed. However, some of these events may be temporary states that can be safely ignored (e.g. a pod fails to schedule for a brief period before succeeding).

We should consider making the list of unrecoverable events customizable in order to avoid unnecessary workspace failures.

Note however that whether these events should be ignored depends on how they occur (i.e. if scheduling fails for ~3-5 seconds it's fine, but if it's longer workspaces could hang for a long time, in which case it makes sense to fail the DevWorkspace).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Projects
None yet
2 participants