Merge pull request #125 from yangcao77/686-parent-version-check

error out if import devfile version is greater than child

Author: yangcao77

go.mod

@@ -10,6 +10,7 @@ require (
 	github.com/google/go-cmp v0.5.5
 	github.com/gregjones/httpcache v0.0.0-20180305231024-9cad4c3443a7
 	github.com/hashicorp/go-multierror v1.1.1
+	github.com/hashicorp/go-version v1.3.0
 	github.com/kylelemons/godebug v0.0.0-20170820004349-d65d576e9348
 	github.com/mattn/go-colorable v0.1.2 // indirect
 	github.com/mattn/go-isatty v0.0.12 // indirect

go.sum

@@ -231,6 +231,8 @@ github.com/hashicorp/go-sockaddr v1.0.0/go.mod h1:7Xibr9yA9JjQq1JpNB2Vw7kxv8xerX
 github.com/hashicorp/go-syslog v1.0.0/go.mod h1:qPfqrKkXGihmCqbJM2mZgkZGvKG1dFdvsLplgctolz4=
 github.com/hashicorp/go-uuid v1.0.0/go.mod h1:6SBZvOh/SIDV7/2o3Jml5SYk/TvGqwFJ/bN7x4byOro=
 github.com/hashicorp/go-uuid v1.0.1/go.mod h1:6SBZvOh/SIDV7/2o3Jml5SYk/TvGqwFJ/bN7x4byOro=
+github.com/hashicorp/go-version v1.3.0 h1:McDWVJIU/y+u1BRV06dPaLfLCaT7fUTJLp5r04x7iNw=
+github.com/hashicorp/go-version v1.3.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09ZGVZPK5anwXA=
 github.com/hashicorp/go.net v0.0.1/go.mod h1:hjKkEWcCURg++eb33jQU7oqQcI9XDCnUzHA0oac0k90=
 github.com/hashicorp/golang-lru v0.5.0/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8=
 github.com/hashicorp/golang-lru v0.5.1/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8=

pkg/devfile/parser/parse.go

@@ -22,6 +22,7 @@ import (
 	v1 "github.com/devfile/api/v2/pkg/apis/workspaces/v1alpha2"
 	apiOverride "github.com/devfile/api/v2/pkg/utils/overriding"
 	"github.com/devfile/api/v2/pkg/validation"
+	versionpkg "github.com/hashicorp/go-version"
 	"github.com/pkg/errors"
 )
 
@@ -192,6 +193,18 @@ func ParseFromData(data []byte) (d DevfileObj, err error) {
 
 func parseParentAndPlugin(d DevfileObj, resolveCtx *resolutionContextTree, tool resolverTools) (err error) {
 	flattenedParent := &v1.DevWorkspaceTemplateSpecContent{}
+	var mainDevfileVersion, parentDevfileVerson, pluginDevfileVerson *versionpkg.Version
+	var devfileVersion string
+	if devfileVersion = d.Ctx.GetApiVersion(); devfileVersion == "" {
+		devfileVersion = d.Data.GetSchemaVersion()
+	}
+
+	if devfileVersion != "" {
+		mainDevfileVersion, err = versionpkg.NewVersion(devfileVersion)
+		if err != nil {
+			return fmt.Errorf("fail to parse version of the main devfile")
+		}
+	}
 	parent := d.Data.GetParent()
 	if parent != nil {
 		if !reflect.DeepEqual(parent, &v1.Parent{}) {
@@ -210,7 +223,20 @@ func parseParentAndPlugin(d DevfileObj, resolveCtx *resolutionContextTree, tool
 			if err != nil {
 				return err
 			}
+			var devfileVersion string
+			if devfileVersion = parentDevfileObj.Ctx.GetApiVersion(); devfileVersion == "" {
+				devfileVersion = parentDevfileObj.Data.GetSchemaVersion()
+			}
 
+			if devfileVersion != "" {
+				parentDevfileVerson, err = versionpkg.NewVersion(devfileVersion)
+				if err != nil {
+					return fmt.Errorf("fail to parse version of parent devfile from: %v", resolveImportReference(parent.ImportReference))
+				}
+				if parentDevfileVerson.GreaterThan(mainDevfileVersion) {
+					return fmt.Errorf("the parent devfile version from %v is greater than the child devfile version from %v", resolveImportReference(parent.ImportReference), resolveImportReference(resolveCtx.importReference))
+				}
+			}
 			parentWorkspaceContent := parentDevfileObj.Data.GetDevfileWorkspaceSpecContent()
 			// add attribute to parent elements
 			err = addSourceAttributesForOverrideAndMerge(parent.ImportReference, parentWorkspaceContent)
@@ -258,6 +284,20 @@ func parseParentAndPlugin(d DevfileObj, resolveCtx *resolutionContextTree, tool
 			if err != nil {
 				return err
 			}
+			var devfileVersion string
+			if devfileVersion = pluginDevfileObj.Ctx.GetApiVersion(); devfileVersion == "" {
+				devfileVersion = pluginDevfileObj.Data.GetSchemaVersion()
+			}
+
+			if devfileVersion != "" {
+				pluginDevfileVerson, err = versionpkg.NewVersion(devfileVersion)
+				if err != nil {
+					return fmt.Errorf("fail to parse version of plugin devfile from: %v", resolveImportReference(component.Plugin.ImportReference))
+				}
+				if pluginDevfileVerson.GreaterThan(mainDevfileVersion) {
+					return fmt.Errorf("the plugin devfile version from %v is greater than the child devfile version from %v", resolveImportReference(component.Plugin.ImportReference), resolveImportReference(resolveCtx.importReference))
+				}
+			}
 			pluginWorkspaceContent := pluginDevfileObj.Data.GetDevfileWorkspaceSpecContent()
 			// add attribute to plugin elements
 			err = addSourceAttributesForOverrideAndMerge(plugin.ImportReference, pluginWorkspaceContent)