Merge pull request #445 from devstress/copilot/remove-previous-learning-properties

Remove environment variable state restoration from test teardown

Author: devstress

.gitignore

@@ -145,3 +145,4 @@ test-results*/
 # Release testing artifacts - built packages and docker images
 packages/
 docker/
+nul

LocalTesting/LocalTesting.IntegrationTests/GlobalTestInfrastructure.cs

@@ -18,8 +18,6 @@ public class GlobalTestInfrastructure
 {
 
     private static readonly TimeSpan DefaultTimeout = TimeSpan.FromSeconds(60);
-    private static string? _previousLearningCourseMode;
-    private static string? _previousIsTestingMode;
 
     public static DistributedApplication? AppHost
     {
@@ -55,14 +53,6 @@ public async Task GlobalSetUp()
 
         try
         {
-            // Save previous environment variable values for restoration
-            _previousLearningCourseMode = Environment.GetEnvironmentVariable("LEARNINGCOURSE");
-            _previousIsTestingMode = Environment.GetEnvironmentVariable("IS_TESTING");
-
-            if (string.Equals(_previousLearningCourseMode, "true", StringComparison.OrdinalIgnoreCase))
-            {
-                Console.WriteLine("⚠️ LEARNINGCOURSE=true detected - forcing Aspire integration-test profile.");
-            }
             Environment.SetEnvironmentVariable("LEARNINGCOURSE", "false");
 
             // Set IS_TESTING environment variable to indicate testing mode
@@ -265,10 +255,10 @@ public async Task GlobalTearDown()
             }
         }
 
-        // Restore previous environment variable values
-        Environment.SetEnvironmentVariable("LEARNINGCOURSE", _previousLearningCourseMode);
-        Environment.SetEnvironmentVariable("IS_TESTING", _previousIsTestingMode);
-        Console.WriteLine("✅ Environment variables restored");
+        // Remove environment variables
+        Environment.SetEnvironmentVariable("LEARNINGCOURSE", null);
+        Environment.SetEnvironmentVariable("IS_TESTING", null);
+        Console.WriteLine("✅ Environment variables removed");
     }
 
     /// <summary>

ObservabilityTesting/ObservabilityTesting.IntegrationTests/GlobalTestInfrastructure.cs

@@ -17,7 +17,6 @@ public class GlobalTestInfrastructure
 {
 
     private static readonly TimeSpan DefaultTimeout = TimeSpan.FromSeconds(60); // Balanced timeout: enough for TaskManager registration, faster failure detection
-    private static string? _previousLearningCourseMode;
 
     public static DistributedApplication? AppHost
     {
@@ -50,7 +49,6 @@ public async Task GlobalSetUp()
 
         try
         {
-            _previousLearningCourseMode = Environment.GetEnvironmentVariable("LEARNINGCOURSE");
             // ObservabilityTesting ALWAYS runs in LEARNINGCOURSE mode (Prometheus/Grafana stack required)
             // No environment variable check needed - we force it to true
             Console.WriteLine("✅ Setting LEARNINGCOURSE=true for ObservabilityTesting (always enabled)");
@@ -263,7 +261,8 @@ public async Task GlobalTearDown()
             }
         }
 
-        Environment.SetEnvironmentVariable("LEARNINGCOURSE", _previousLearningCourseMode);
+        // Remove environment variable
+        Environment.SetEnvironmentVariable("LEARNINGCOURSE", null);
     }
 
     /// <summary>