Skip to content

chore(cleanup): remove import token feature flag #6912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Jun 2, 2025

Motivation

The nns-dapp uses feature flags to introduce new features into the main branch without disrupting existing flows. Some of these feature flags have been in the code for a long time, so we want to remove them.

This PR removes the feature flags introduced in #6209.

Changes

  • Removes ENABLE_IMPORT_TOKEN_BY_URL feature flag.
  • Eliminates tests that check the UI behavior when the feature flag is off.
  • Updates tests to reflect the UI behavior when the feature flag is on, as this is the default behavior.

Tests

  • The pipeline should pass as before.
  • Tested in devenv

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@yhabib yhabib changed the title remove ff chore(cleanup): remove import token feature flag Jun 2, 2025
@yhabib yhabib marked this pull request as ready for review June 2, 2025 09:10
@yhabib yhabib requested a review from a team as a code owner June 2, 2025 09:10
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@yhabib yhabib added this pull request to the merge queue Jun 4, 2025
Merged via the queue into main with commit 09b6cf1 Jun 4, 2025
36 checks passed
@yhabib yhabib deleted the nns1-3510/import branch June 4, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants