Skip to content
clang-tidy check

Handle loaded MPQ files in a map instead of bespoke globals #54

Sign in to view logs

Handle loaded MPQ files in a map instead of bespoke globals

Handle loaded MPQ files in a map instead of bespoke globals #54

Triggered via pull request March 31, 2025 07:48
@AJenboAJenbo
synchronize #7887
dyn-mpq
Status Success
Total duration 50s
Artifacts –
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

clang-tidy-check.yml

on: pull_request
tidy-check
45s
tidy-check
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 10 warnings
test/pack_test.cpp:3:10 [clang-diagnostic-error]: test/pack_test.cpp#L3
'gtest/gtest.h' file not found
test/inv_test.cpp:1:10 [clang-diagnostic-error]: test/inv_test.cpp#L1
'gtest/gtest.h' file not found
test/dun_render_benchmark.cpp:4:10 [clang-diagnostic-error]: test/dun_render_benchmark.cpp#L4
'ankerl/unordered_dense.h' file not found
Source/player.h:8:10 [clang-diagnostic-error]: Source/player.h#L8
'cstdint' file not found
Source/init.h:8:10 [clang-diagnostic-error]: Source/init.h#L8
'optional' file not found
Source/engine/sound.cpp:6:10 [clang-diagnostic-error]: Source/engine/sound.cpp#L6
'engine/sound.h' file not found
Source/engine/assets.hpp:11:10 [clang-diagnostic-error]: Source/engine/assets.hpp#L11
'SDL.h' file not found
Source/engine/assets.cpp:1:10 [clang-diagnostic-error]: Source/engine/assets.cpp#L1
'engine/assets.hpp' file not found
Source/DiabloUI/settingsmenu.cpp:7:10 [clang-diagnostic-error]: Source/DiabloUI/settingsmenu.cpp#L7
'function_ref.hpp' file not found
Source/DiabloUI/mainmenu.cpp:3:10 [clang-diagnostic-error]: Source/DiabloUI/mainmenu.cpp#L3
'DiabloUI/diabloui.h' file not found
Source/DiabloUI/settingsmenu.cpp:371:3 [bugprone-branch-clone]: Source/DiabloUI/settingsmenu.cpp#L371
switch has 3 consecutive identical branches
Source/DiabloUI/settingsmenu.cpp:226:26 [misc-unused-parameters]: Source/DiabloUI/settingsmenu.cpp#L226
parameter 'value' is unused
Source/DiabloUI/settingsmenu.cpp:190:57 [misc-unused-parameters]: Source/DiabloUI/settingsmenu.cpp#L190
parameter 'listIndex' is unused
Source/DiabloUI/settingsmenu.cpp:190:41 [misc-unused-parameters]: Source/DiabloUI/settingsmenu.cpp#L190
parameter 'pOption' is unused
Source/DiabloUI/settingsmenu.cpp:166:25 [misc-unused-parameters]: Source/DiabloUI/settingsmenu.cpp#L166
parameter 'value' is unused
Source/DiabloUI/settingsmenu.cpp:160:50 [misc-unused-parameters]: Source/DiabloUI/settingsmenu.cpp#L160
parameter 'category' is unused
Source/DiabloUI/settingsmenu.cpp:154:47 [misc-unused-parameters]: Source/DiabloUI/settingsmenu.cpp#L154
parameter 'option' is unused
Source/DiabloUI/settingsmenu.cpp:66:36 [misc-unused-parameters]: Source/DiabloUI/settingsmenu.cpp#L66
parameter 'pOptionEntry' is unused
Source/DiabloUI/mainmenu.cpp:96:63 [misc-unused-parameters]: Source/DiabloUI/mainmenu.cpp#L96
parameter 'pdwResult' is unused
Source/DiabloUI/mainmenu.cpp:31:20 [bugprone-narrowing-conversions]: Source/DiabloUI/mainmenu.cpp#L31
narrowing conversion from 'std::size_t' (aka 'unsigned long') to signed type 'int' is implementation-defined