Skip to content

Commit 7de83a5

Browse files
committed
Fix bug which caused javadoc-agg to use the task's group, rather than the maven group.
1 parent 2b755f9 commit 7de83a5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/resources/base/javadoc-agg.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ def javadocAgg = 干.proj('javadoc_agg', 'space-delimited list of projects con
55
def git_url =.proj('git_url', 'the git url with no protocol, e.g.: github.com/diffplug/blowdryer')
66
def javadocLinks =.proj('javadoc_links', "space-delimited links, if you add '/package-list' to the urls you should get a package list").split()
77
group =.proj('maven_group', 'the maven group, recommend com.diffplug')
8+
def maven_group = group
89
def license =.proj('license', 'supported: apache')
910
def license_name =.prop('base/maven', "${license}_name")
1011
def license_url =.prop('base/maven', "${license}_url")
@@ -37,7 +38,7 @@ def rootJavadoc = tasks.register('javadoc', Javadoc) {
3738

3839
// copied from base/maven
3940
def makeLink = { url, text -> "<a href=\"${url}\" style=\"text-transform: none;\">${text}</a>" }
40-
def javadocInfo = '<h2>' + makeLink("https://${git_url}", "${group}:${maven_artifact}:${version}") +
41+
def javadocInfo = '<h2>' + makeLink("https://${git_url}", "${maven_group}:${maven_artifact}:${version}") +
4142
' by ' + makeLink('https://www.diffplug.com', 'DiffPlug') + '</h2>';
4243
// Where it's possible to name parameters and methods clearly enough
4344
// that javadoc is not necessary, why make the code bigger?

0 commit comments

Comments
 (0)