c-sources cannot have cmm files

[Kleidukos]

'sup, cabal team here.

You have a problem when you generate cabal files:

        [ "      c-sources:" ] ++
        indent3 [ "libraries/ghc-heap/cbits/HeapPrim.cmm" ] ++

This cannot possibly work, was giving the appearance of normality, but ultimately this is the wrong stanza. cmm-sources must be used.

Cheers

[vaibhavsagar]

When I patched this in my own project, I also had to change the cabal-version (and also the license field) to one that supported this stanza.

[shayne-fletcher]

this was in fact updated last month (#492) to read

        [ "    if impl(ghc >= 9.2.2) "] ++ -- cabal >= 3.6.0
        [ "      cmm-sources:" ] ++
        indent3 [ "libraries/ghc-heap/cbits/HeapPrim.cmm" ] ++
        [ "    else" ] ++
        [ "      c-sources:" ] ++
        indent3 [ "libraries/ghc-heap/cbits/HeapPrim.cmm" ] ++

@Kleidukos does that look ok?

[Kleidukos]

@cho-m Which compiler did you use with ghc-lib-parser-9.8.1.20231009/ghc-lib-parser-9.6.2.20230523 ?

[shayne-fletcher]

i see that ghc-lib-parser-9.8.1-9.8.1.20231009 on hackage is still using cabal-version 2.0 and doesn't have that switching logic so that .cmm files are listed in c-sources. i assume this is causing issues - i'll put a new version up!

[cho-m]

Confirmed locally that new ghc-lib-parser-9.8.1.20231121 works with cabal-install == 3.10.2.1.

[shayne-fletcher]

have pushed ghc-lib-9.8.1.20231121, ghc-lib-9.6.3.20231121 and ghc-lib-9.6.2.20231121 to hackage.

[shayne-fletcher]

@garyverhaegen-da i think this issue is good to close now