Skip to content

Subframes with default values are not causing matches #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dlongley opened this issue Jul 26, 2019 · 2 comments
Closed

Subframes with default values are not causing matches #323

dlongley opened this issue Jul 26, 2019 · 2 comments

Comments

@dlongley
Copy link
Member

See: w3c/json-ld-syntax#19

I think that this is just a bug in the jsonld.js implementation, the matchesSome flag is not set to true when a default is set in the subframe but the key (states in that issue) is not present in the data.

Adding matchesSome = true before continuing here would fix it:
https://github.com/digitalbazaar/jsonld.js/blob/master/lib/frame.js#L471

Possible duplicate of #155.

@gkellogg
Copy link
Collaborator

I think this was for w3c/json-ld-framing#58.

@dlongley
Copy link
Member Author

My understanding is that this has been fixed, closing. If not fixed, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants