Skip to content

Incorrect default cast from MSSQL int (auto-increment) to PG bigserial #1590

Open
@nathanael-ruf

Description

@nathanael-ruf

int is 4 bytes in mssql: https://learn.microsoft.com/en-us/sql/t-sql/data-types/int-bigint-smallint-and-tinyint-transact-sql?view=sql-server-ver16
bigserial is 8 bytes: https://www.postgresql.org/docs/current/datatype-numeric.html

Expected: pgloader converts to serial (4 bytes).

Besides just more space this has implications for node applications using the pg library which returns strings instead of numbers because numbers in js can't represent full 64bit integers.

Location in the code:

(:source (:type "int" :auto-increment t)
:target (:type "bigserial" :drop-default t))

(related: #1586. I only found this issue after applying the fix of #1586 on a fork)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions