Skip to content

Commit 97c9f1f

Browse files
committed
improve externaliser tests
.
1 parent 6eb00bf commit 97c9f1f

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

test/unit/model/book_key_externaliser_test.dart

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,27 @@
11
import 'package:bible_feed/model/book_key_externaliser.dart';
22
import 'package:flutter_test/flutter_test.dart';
3+
import 'package:bible_feed/model/reading_lists.dart';
4+
5+
class ProdReadingListsModule extends ReadingListsModule {}
36

47
void main() {
58
void runTest(BookKeyExternaliser testee, Map<String, String> expectedMappings) {
9+
final defaultMappings = <String, String>{};
10+
for (final readingList in ProdReadingListsModule().readingLists) {
11+
for (final book in readingList) {
12+
defaultMappings[book.key] = book.key;
13+
}
14+
}
15+
16+
final mergedMappings = Map<String, String>.from(defaultMappings);
17+
mergedMappings.addAll(expectedMappings.map((k, v) => MapEntry(k, v)));
18+
619
group(testee.runtimeType.toString(), () {
7-
expectedMappings.forEach((from, to) {
8-
test('getExternalBookKey "$from" should return "$to"', () {
20+
mergedMappings.forEach((from, to) {
21+
test('${testee.name}.getExternalBookKey "$from" should return "$to"', () {
922
expect(testee.getExternalBookKey(from), to);
1023
});
1124
});
12-
13-
test('getExternalBookKey returns original key for unknown keys', () {
14-
expect(testee.getExternalBookKey('unknown'), 'unknown');
15-
});
1625
});
1726
}
1827

0 commit comments

Comments
 (0)