Drop color mode toggle

[codingjoe]

Hi there,

I love to drop the color mode toggle. Just the toggle, not the modes! The way the color mode implementation has aged a little.
light-dark or prefers-color-scheme are natively available to all systems and would greatly reduce the complexity of our CSS.

I'd believe people rarely want to use light mode when they have their OS set up to dark mode.
Besides, as a dev, you can control it since you have control over your app.

BUT, I'm an oddball, opinions vary, and I know that letting go of a feature is a painful decision.

On the pro side, I think this can really help to shrink the CSS and improve code navigation and readability.
It's nice for us, but nice for us, might lead to other cool features :)

Cheers
Joe

[tim-schilling]

I think it's a good idea for us to support that out of the box, but some sites aren't going to support multiple modes. So us only respecting the system preference, while the project uses light theme, or dark theme could make the experience as a whole, lesser.

[codingjoe]

Let me clarify my intent: it would use whatever the project specified. If your project doesn't support system default but sets a preference, it will use the same theme.

That's what why I thought it might be a slim use case. Do you really want your project in dark mode, but the debug toolbar not?

[codingjoe]

You can control it with the theme meta tag. Either light, dark or both.

[tim-schilling]

Yes, agreed that if the project specifies a theme we should default to that. However, not every project supports a dark/light theme and the project's appearance may conflict with their system default. In that case, allowing the dev to control the toolbar's theme without having to change their code or have the browser developer tools would be helpful.

[codingjoe]

Hm… I see… Oh, that sparks an idea: Maybe we could change the toggle to change the page-wide theme setting. This would even be a pretty cool feature for pages that do support both modes. Because you can debug the front end easily without adding a toggle to your project.

[matthiask]

I like removing features but I think you (or someone else) should be able to make a case for specific improvements which are unblocked or enabled by doing this. Having less code to maintain is an upside, but since we already have the feature and it is working well I don't see a good reason for doing this right now.

[codingjoe]

Fair enough, I believe that's reasonable. Good to know that you are open to the option.