Skip to content

Profiler not correctly filtering files on Windows #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Oisota opened this issue Sep 22, 2023 · 2 comments · Fixed by #1857
Closed

Profiler not correctly filtering files on Windows #1836

Oisota opened this issue Sep 22, 2023 · 2 comments · Fixed by #1857

Comments

@Oisota
Copy link

Oisota commented Sep 22, 2023

The profiler is not filtering out non-project code when running on Windows. The culprit seems to be these lines in the is_project_func method. The forward slashes in the paths will never be in the path when on windows and all non project code gets included in the profile.

I was able to fix the issue locally by simply removing the forward slashes from the two paths. If this is an acceptable fix, I'd be happy to submit a PR.

@tim-schilling
Copy link
Member

Hmm, there's probably a better way to inspect the filepath. I think we'd want to check that these are directories in the filepath and not simply check for the directory name in the filepath. A PR is definitely welcome!

@praffq
Copy link
Contributor

praffq commented Nov 17, 2023

This is my first pull request , any advises would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants