Skip to content

Commit 5eede25

Browse files
benkonrathbenkonrath
committed
Allow model fields to be migrated.
1 parent 743dce3 commit 5eede25

File tree

14 files changed

+17
-144
lines changed

14 files changed

+17
-144
lines changed

‎docs/changelog.rst‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ Modifications to existing flavors:
2727
- Fixed French FRNationalIdentificationNumber bug with corsican people born after 2000.
2828
(`gh-242` <https://github.com/django/django-localflavor/pull/242>`_).
2929

30+
Other changes:
31+
32+
- Ensure the migration framework generates schema migrations for model fields that change the max_length
33+
(`gh-xx <https://github.com/django/django-localflavor/pull/xx>`_).
34+
3035
1.3 (2016-05-06)
3136
------------------
3237

‎localflavor/au/models.py‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ def __init__(self, *args, **kwargs):
2222
def deconstruct(self):
2323
name, path, args, kwargs = super(AUStateField, self).deconstruct()
2424
del kwargs['choices']
25-
del kwargs['max_length']
2625
return name, path, args, kwargs
2726

2827

@@ -38,11 +37,6 @@ def __init__(self, *args, **kwargs):
3837
kwargs['max_length'] = 4
3938
super(AUPostCodeField, self).__init__(*args, **kwargs)
4039

41-
def deconstruct(self):
42-
name, path, args, kwargs = super(AUPostCodeField, self).deconstruct()
43-
del kwargs['max_length']
44-
return name, path, args, kwargs
45-
4640
def formfield(self, **kwargs):
4741
defaults = {'form_class': forms.AUPostCodeField}
4842
defaults.update(kwargs)
@@ -60,11 +54,6 @@ def __init__(self, *args, **kwargs):
6054
kwargs['max_length'] = 20
6155
super(AUPhoneNumberField, self).__init__(*args, **kwargs)
6256

63-
def deconstruct(self):
64-
name, path, args, kwargs = super(AUPhoneNumberField, self).deconstruct()
65-
del kwargs['max_length']
66-
return name, path, args, kwargs
67-
6857
def formfield(self, **kwargs):
6958
defaults = {'form_class': forms.AUPhoneNumberField}
7059
defaults.update(kwargs)
@@ -87,11 +76,6 @@ def __init__(self, *args, **kwargs):
8776
kwargs['max_length'] = 11
8877
super(AUBusinessNumberField, self).__init__(*args, **kwargs)
8978

90-
def deconstruct(self):
91-
name, path, args, kwargs = super(AUBusinessNumberField, self).deconstruct()
92-
del kwargs['max_length']
93-
return name, path, args, kwargs
94-
9579
def formfield(self, **kwargs):
9680
defaults = {'form_class': forms.AUBusinessNumberField}
9781
defaults.update(kwargs)
@@ -128,11 +112,6 @@ def __init__(self, *args, **kwargs):
128112
kwargs['max_length'] = 11
129113
super(AUTaxFileNumberField, self).__init__(*args, **kwargs)
130114

131-
def deconstruct(self):
132-
name, path, args, kwargs = super(AUTaxFileNumberField, self).deconstruct()
133-
del kwargs['max_length']
134-
return name, path, args, kwargs
135-
136115
def formfield(self, **kwargs):
137116
defaults = {'form_class': forms.AUTaxFileNumberField}
138117
defaults.update(kwargs)

‎localflavor/bg/models.py‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ def __init__(self, *args, **kwargs):
1717
kwargs['max_length'] = 10
1818
super(BGEGNField, self).__init__(*args, **kwargs)
1919

20-
def deconstruct(self):
21-
name, path, args, kwargs = super(BGEGNField, self).deconstruct()
22-
del kwargs['max_length']
23-
return name, path, args, kwargs
24-
2520

2621
class BGEIKField(models.CharField):
2722
"""
@@ -36,8 +31,3 @@ class BGEIKField(models.CharField):
3631
def __init__(self, *args, **kwargs):
3732
kwargs['max_length'] = 13
3833
super(BGEIKField, self).__init__(*args, **kwargs)
39-
40-
def deconstruct(self):
41-
name, path, args, kwargs = super(BGEIKField, self).deconstruct()
42-
del kwargs['max_length']
43-
return name, path, args, kwargs

‎localflavor/br/models.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,4 @@ def __init__(self, *args, **kwargs):
1818
def deconstruct(self):
1919
name, path, args, kwargs = super(BRStateField, self).deconstruct()
2020
del kwargs['choices']
21-
del kwargs['max_length']
2221
return name, path, args, kwargs

‎localflavor/ec/models.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,4 @@ def __init__(self, *args, **kwargs):
2121
def deconstruct(self):
2222
name, path, args, kwargs = super(ECProvinceField, self).deconstruct()
2323
del kwargs['choices']
24-
del kwargs['max_length']
2524
return name, path, args, kwargs

‎localflavor/fr/models.py‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ def __init__(self, *args, **kwargs):
1515
kwargs['max_length'] = 9
1616
super(FRSIRENField, self).__init__(*args, **kwargs)
1717

18-
def deconstruct(self):
19-
name, path, args, kwargs = super(FRSIRENField, self).deconstruct()
20-
del kwargs['max_length']
21-
return name, path, args, kwargs
22-
2318
def formfield(self, **kwargs):
2419
from . import forms
2520
defaults = {'form_class': forms.FRSIRENField}
@@ -40,11 +35,6 @@ def __init__(self, *args, **kwargs):
4035
kwargs['max_length'] = 14
4136
super(FRSIRETField, self).__init__(*args, **kwargs)
4237

43-
def deconstruct(self):
44-
name, path, args, kwargs = super(FRSIRETField, self).deconstruct()
45-
del kwargs['max_length']
46-
return name, path, args, kwargs
47-
4838
def formfield(self, **kwargs):
4939
from . import forms
5040
defaults = {'form_class': forms.FRSIRETField}

‎localflavor/generic/models.py‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ def __init__(self, *args, **kwargs):
4444

4545
def deconstruct(self):
4646
name, path, args, kwargs = super(IBANField, self).deconstruct()
47-
del kwargs['max_length']
4847
kwargs['use_nordea_extensions'] = self.use_nordea_extensions
4948
kwargs['include_countries'] = self.include_countries
5049
return name, path, args, kwargs
@@ -82,11 +81,6 @@ def __init__(self, *args, **kwargs):
8281
super(BICField, self).__init__(*args, **kwargs)
8382
self.validators.append(BICValidator())
8483

85-
def deconstruct(self):
86-
name, path, args, kwargs = super(BICField, self).deconstruct()
87-
del kwargs['max_length']
88-
return name, path, args, kwargs
89-
9084
def to_python(self, value):
9185
# BIC is always written in upper case.
9286
# https://www2.swift.com/uhbonline/books/public/en_uk/bic_policy/bic_policy.pdf

‎localflavor/in_/models.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,4 @@ def __init__(self, *args, **kwargs):
1919
def deconstruct(self):
2020
name, path, args, kwargs = super(INStateField, self).deconstruct()
2121
del kwargs['choices']
22-
del kwargs['max_length']
2322
return name, path, args, kwargs

‎localflavor/mk/models.py‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ def __init__(self, *args, **kwargs):
1717
kwargs['max_length'] = 8
1818
super(MKIdentityCardNumberField, self).__init__(*args, **kwargs)
1919

20-
def deconstruct(self):
21-
name, path, args, kwargs = super(MKIdentityCardNumberField, self).deconstruct()
22-
del kwargs['max_length']
23-
return name, path, args, kwargs
24-
2520
def formfield(self, **kwargs):
2621
defaults = {'form_class': MKIdentityCardNumberFormField}
2722
defaults.update(kwargs)
@@ -43,7 +38,6 @@ def __init__(self, *args, **kwargs):
4338
def deconstruct(self):
4439
name, path, args, kwargs = super(MKMunicipalityField, self).deconstruct()
4540
del kwargs['choices']
46-
del kwargs['max_length']
4741
return name, path, args, kwargs
4842

4943

@@ -67,11 +61,6 @@ def __init__(self, *args, **kwargs):
6761
kwargs['max_length'] = 13
6862
super(UMCNField, self).__init__(*args, **kwargs)
6963

70-
def deconstruct(self):
71-
name, path, args, kwargs = super(UMCNField, self).deconstruct()
72-
del kwargs['max_length']
73-
return name, path, args, kwargs
74-
7564
def formfield(self, **kwargs):
7665
defaults = {'form_class': UMCNFormField}
7766
defaults.update(kwargs)

‎localflavor/mx/models.py‎

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ def __init__(self, *args, **kwargs):
2424
def deconstruct(self):
2525
name, path, args, kwargs = super(MXStateField, self).deconstruct()
2626
del kwargs['choices']
27-
del kwargs['max_length']
2827
return name, path, args, kwargs
2928

3029

@@ -39,11 +38,6 @@ def __init__(self, *args, **kwargs):
3938
kwargs['max_length'] = 5
4039
super(MXZipCodeField, self).__init__(*args, **kwargs)
4140

42-
def deconstruct(self):
43-
name, path, args, kwargs = super(MXZipCodeField, self).deconstruct()
44-
del kwargs['max_length']
45-
return name, path, args, kwargs
46-
4741
def formfield(self, **kwargs):
4842
defaults = {'form_class': MXZipCodeFormField}
4943
defaults.update(kwargs)
@@ -61,11 +55,6 @@ def __init__(self, *args, **kwargs):
6155
kwargs['max_length'] = 13
6256
super(MXRFCField, self).__init__(*args, **kwargs)
6357

64-
def deconstruct(self):
65-
name, path, args, kwargs = super(MXRFCField, self).deconstruct()
66-
del kwargs['max_length']
67-
return name, path, args, kwargs
68-
6958
def formfield(self, **kwargs):
7059
defaults = {'form_class': MXRFCFormField}
7160
defaults.update(kwargs)
@@ -85,11 +74,6 @@ def __init__(self, *args, **kwargs):
8574
kwargs['max_length'] = 18
8675
super(MXCLABEField, self).__init__(*args, **kwargs)
8776

88-
def deconstruct(self):
89-
name, path, args, kwargs = super(MXCLABEField, self).deconstruct()
90-
del kwargs['max_length']
91-
return name, path, args, kwargs
92-
9377
def formfield(self, **kwargs):
9478
defaults = {'form_class': MXCLABEFormField}
9579
defaults.update(kwargs)
@@ -107,11 +91,6 @@ def __init__(self, *args, **kwargs):
10791
kwargs['max_length'] = 18
10892
super(MXCURPField, self).__init__(*args, **kwargs)
10993

110-
def deconstruct(self):
111-
name, path, args, kwargs = super(MXCURPField, self).deconstruct()
112-
del kwargs['max_length']
113-
return name, path, args, kwargs
114-
11594
def formfield(self, **kwargs):
11695
defaults = {'form_class': MXCURPFormField}
11796
defaults.update(kwargs)
@@ -129,11 +108,6 @@ def __init__(self, *args, **kwargs):
129108
kwargs['max_length'] = 11
130109
super(MXSocialSecurityNumberField, self).__init__(*args, **kwargs)
131110

132-
def deconstruct(self):
133-
name, path, args, kwargs = super(MXSocialSecurityNumberField, self).deconstruct()
134-
del kwargs['max_length']
135-
return name, path, args, kwargs
136-
137111
def formfield(self, **kwargs):
138112
defaults = {'form_class': MXSocialSecurityNumberFormField}
139113
defaults.update(kwargs)

0 commit comments

Comments
 (0)