Closed
Conversation
Member
|
@svmalvaez Please edit the description of this PR to add a description of your change along with the relevant check box items. |
| ('BCN', _('Baja California')), | ||
| ('BCS', _('Baja California Sur')), | ||
| ('CAM', _('Campeche')), | ||
| ('CDMX', _('Ciudad de México')), |
Member
There was a problem hiding this comment.
The state field is 3 characters long this won't work. You'll also need to modify the tests for this change.
Contributor
There was a problem hiding this comment.
Would be using the three letter airport code for Ciudad de México (MEX) a fix for this?
There was a problem hiding this comment.
@jackboot7 the official abbreviation is CDMX, so it would probably need the state field to be updated.
There was a problem hiding this comment.
Also I believe it can be confusing with "Estado de México" which is a different state, I know its not very conventional but as a compromise could it be CMX ??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution!
A checklist is included below which helps us keep the code contributions
consistent and helps speed up the review process. You can add additional
commits to your pull request if you haven't met all of these points on your
first version. You'll be asked to rebase and squash the commits before the
final merge.
Please replace these instructions with a description of your change. The
'New Fields Only' checkboxes should be removed as well if your pull request
doesn't add any new fields.
All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.
Adjust your imports to a standard form by running this command:
isort --recursive --line-width 120 localflavor testsNew Fields Only
localflavor country. This means that English translations are usually
not the best name unless it's for something standard like postal code,
tax / VAT ID etc.
international English; ZipCode is a term specific to the United
States postal system.
validation edge cases should be covered.
.. versionadded:: <next-version>comment markers to newlocalflavors.