Skip to content

Change DIF to CDMX in mx_states#235

Closed
svmalvaez wants to merge 1 commit intodjango:masterfrom
svmalvaez:fix/new-mx-state-cdmx
Closed

Change DIF to CDMX in mx_states#235
svmalvaez wants to merge 1 commit intodjango:masterfrom
svmalvaez:fix/new-mx-state-cdmx

Conversation

@svmalvaez
Copy link
Copy Markdown

Thanks for your contribution!

A checklist is included below which helps us keep the code contributions
consistent and helps speed up the review process. You can add additional
commits to your pull request if you haven't met all of these points on your
first version. You'll be asked to rebase and squash the commits before the
final merge.

Please replace these instructions with a description of your change. The
'New Fields Only' checkboxes should be removed as well if your pull request
doesn't add any new fields.

All Changes

  • Add an entry to the docs/changelog.rst describing the change.

  • Add an entry for your name in the docs/authors.rst file if it's not
    already there.

  • Adjust your imports to a standard form by running this command:

    isort --recursive --line-width 120 localflavor tests

New Fields Only

  • Prefix the country code to all fields.
  • Field names should be easily understood by developers from the target
    localflavor country. This means that English translations are usually
    not the best name unless it's for something standard like postal code,
    tax / VAT ID etc.
  • Prefer 'PostalCodeField' for postal codes as it's
    international English; ZipCode is a term specific to the United
    States postal system.
  • Add meaningful tests. 100% test coverage is not required but all
    validation edge cases should be covered.
  • Add .. versionadded:: <next-version> comment markers to new
    localflavors.
  • Add documentation for all fields.

@benkonrath
Copy link
Copy Markdown
Member

@svmalvaez Please edit the description of this PR to add a description of your change along with the relevant check box items.

('BCN', _('Baja California')),
('BCS', _('Baja California Sur')),
('CAM', _('Campeche')),
('CDMX', _('Ciudad de México')),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The state field is 3 characters long this won't work. You'll also need to modify the tests for this change.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be using the three letter airport code for Ciudad de México (MEX) a fix for this?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackboot7 the official abbreviation is CDMX, so it would probably need the state field to be updated.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I believe it can be confusing with "Estado de México" which is a different state, I know its not very conventional but as a compromise could it be CMX ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants