Move Type.needsCopyOrPostblit to typesem (#22194)

Author: elshorbagyx

compiler/src/dmd/cxxfrontend.d

@@ -1078,6 +1078,12 @@ bool needsDestruction(Type type)
     return dmd.typesem.needsDestruction(type);
 }
 
+bool needsCopyOrPostblit(Type type)
+{
+    import dmd.typesem;
+    return dmd.typesem.needsCopyOrPostblit(type);
+}
+
 /***********************************************************
  * typinf.d
  */

compiler/src/dmd/frontend.h

@@ -2088,7 +2088,6 @@ class Type : public ASTNode
     virtual int32_t hasWild() const;
     virtual Type* nextOf();
     Type* baseElemOf();
-    virtual bool needsCopyOrPostblit();
     virtual TypeBasic* isTypeBasic();
     TypeFunction* isPtrToFunction();
     TypeFunction* isFunction_Delegate_PtrToFunction();
@@ -4428,7 +4427,6 @@ class TypeEnum final : public Type
     const char* kind() const override;
     TypeEnum* syntaxCopy() override;
     bool isScalar() override;
-    bool needsCopyOrPostblit() override;
     Type* nextOf() override;
     void accept(Visitor* v) override;
 };
@@ -4652,7 +4650,6 @@ class TypeSArray final : public TypeArray
     const char* kind() const override;
     TypeSArray* syntaxCopy() override;
     bool isIncomplete();
-    bool needsCopyOrPostblit() override;
     void accept(Visitor* v) override;
 };
 
@@ -4675,7 +4672,6 @@ class TypeStruct final : public Type
     static TypeStruct* create(StructDeclaration* sym);
     const char* kind() const override;
     TypeStruct* syntaxCopy() override;
-    bool needsCopyOrPostblit() override;
     void accept(Visitor* v) override;
 };
 

compiler/src/dmd/mtype.d

@@ -1206,15 +1206,6 @@ extern (C++) abstract class Type : ASTNode
         return m;
     }
 
-    /********************************
-     * true if when type is copied, it needs a copy constructor or postblit
-     * applied. Only applies to value types, not ref types.
-     */
-    bool needsCopyOrPostblit()
-    {
-        return false;
-    }
-
     // For eliminating dynamic_cast
     TypeBasic isTypeBasic()
     {
@@ -1650,11 +1641,6 @@ extern (C++) final class TypeSArray : TypeArray
         return dim.isIntegerExp() && dim.isIntegerExp().getInteger() == 0;
     }
 
-    override bool needsCopyOrPostblit()
-    {
-        return next.needsCopyOrPostblit();
-    }
-
     override void accept(Visitor v)
     {
         v.visit(this);
@@ -2346,11 +2332,6 @@ extern (C++) final class TypeStruct : Type
         return this;
     }
 
-    override bool needsCopyOrPostblit()
-    {
-        return sym.hasCopyCtor || sym.postblit;
-    }
-
     override void accept(Visitor v)
     {
         v.visit(this);
@@ -2384,11 +2365,6 @@ extern (C++) final class TypeEnum : Type
         return this.memType().isScalar();
     }
 
-    override bool needsCopyOrPostblit()
-    {
-        return this.memType().needsCopyOrPostblit();
-    }
-
     override Type nextOf()
     {
         return this.memType().nextOf();

compiler/src/dmd/mtype.h

@@ -248,7 +248,6 @@ class Type : public ASTNode
     virtual int hasWild() const;
     virtual Type *nextOf();
     Type *baseElemOf();
-    virtual bool needsCopyOrPostblit();
 
     TypeFunction *toTypeFunction();
 
@@ -346,7 +345,6 @@ class TypeSArray final : public TypeArray
     const char *kind() override;
     TypeSArray *syntaxCopy() override;
     bool isIncomplete();
-    bool needsCopyOrPostblit() override;
 
     void accept(Visitor *v) override { v->visit(this); }
 };
@@ -623,7 +621,6 @@ class TypeStruct final : public Type
     static TypeStruct *create(StructDeclaration *sym);
     const char *kind() override;
     TypeStruct *syntaxCopy() override;
-    bool needsCopyOrPostblit() override;
 
     void accept(Visitor *v) override { v->visit(this); }
 };
@@ -636,7 +633,6 @@ class TypeEnum final : public Type
     const char *kind() override;
     TypeEnum *syntaxCopy() override;
     bool isScalar() override;
-    bool needsCopyOrPostblit() override;
     Type *nextOf() override;
 
     void accept(Visitor *v) override { v->visit(this); }
@@ -780,4 +776,5 @@ namespace dmd
     bool isUnsigned(Type* type);
     bool needsNested(Type* type);
     bool needsDestruction(Type* type);
+    bool needsCopyOrPostblit(Type* type);
 }

compiler/src/dmd/typesem.d

@@ -83,6 +83,21 @@ private inout(TypeNext) isTypeNext(inout Type _this)
     }
 }
 
+/********************************
+ * true if when type is copied, it needs a copy constructor or postblit
+ * applied. Only applies to value types, not ref types.
+ */
+bool needsCopyOrPostblit(Type _this)
+{
+    if (auto tsa = _this.isTypeSArray())
+        return tsa.next.needsCopyOrPostblit();
+    else if (auto ts = _this.isTypeStruct())
+        return ts.sym.hasCopyCtor || ts.sym.postblit;
+    else if (auto te = _this.isTypeEnum())
+        return te.memType().needsCopyOrPostblit();
+    return false;
+}
+
 /********************************
  * true if when type goes out of scope, it needs a destructor applied.
  * Only applies to value types, not ref types.