Skip to content

Move semantic methods out of expression.d #8479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Jul 9, 2018

Trying to remove semantic dependencies from expression.d. Next step is to create a visitor toBoolean methods and after that, hopefully, we can get rid of the expressionsem and dsymbolsem dependencies.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8479"

@RazvanN7 RazvanN7 requested a review from jacob-carlborg as a code owner July 9, 2018 12:21
@wilzbach wilzbach closed this Jul 10, 2018
@wilzbach wilzbach reopened this Jul 10, 2018
@wilzbach wilzbach merged commit 9aaeadc into dlang:master Jul 10, 2018
@WalterBright
Copy link
Member

Trying to remove semantic dependencies from expression.d.

Rationale?

@RazvanN7
Copy link
Contributor Author

@WalterBright Trying to pull out semantic methods out of AST nodes so that we can have a separation between parsing and semantic analysis. This will enable to replace the massive duplication in ASTBase with simple imports of AST nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants