Skip to content

Commit 5665454

Browse files
committed
handled formatting problem and adapted CI to use the new test commands
1 parent 7a0de28 commit 5665454

File tree

2 files changed

+12
-14
lines changed

2 files changed

+12
-14
lines changed

.github/workflows/test_tools_dashboard.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -107,15 +107,13 @@ jobs:
107107
# Run workspace dashboard e2e tests (does not pass with python 3.9
108108
- name: Run dashboard e2e
109109
run: |
110-
marimo run --headless dlt/_workspace/helpers/dashboard/dlt_dashboard.py -- -- --pipelines-dir _storage/.dlt/pipelines/ --with_test_identifiers true & pytest --browser chromium tests/e2e
110+
pytest --browser chromium tests/e2e/helpers/dashboard
111111
if: matrix.python-version != '3.9' && matrix.python-version != '3.14.0-beta.4' && matrix.os != 'windows-latest'
112112

113113
# note that this test will pass only when running from cmd shell (_storage\.dlt\pipelines\ must stay)
114114
- name: Run dashboard e2e windows
115115
run: |
116-
start marimo run --headless dlt/_workspace/helpers/dashboard/dlt_dashboard.py -- -- --pipelines-dir _storage\.dlt\pipelines\ --with_test_identifiers true
117-
timeout /t 6 /nobreak
118-
pytest --browser chromium tests/e2e
116+
pytest --browser chromium tests/e2e/helpers/dashboard
119117
if: matrix.python-version != '3.9' && matrix.python-version != '3.14.0-beta.4' && matrix.os == 'windows-latest'
120118

121119
matrix_job_required_check:

dlt/_workspace/helpers/dashboard/dlt_dashboard.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1164,17 +1164,17 @@ def utils_cli_args_and_query_vars_config():
11641164
Prepare cli args as globals for the following cells
11651165
"""
11661166
_run_context = dlt.current.run_context()
1167-
mo_query_var_pipeline_name = None
1168-
mo_cli_arg_pipelines_dir = None
1169-
mo_cli_arg_with_test_identifiers = False
1170-
mo_cli_arg_pipeline = None
1171-
mo_query_var_profile = None
1172-
mo_cli_arg_profile = None
1167+
mo_query_var_pipeline_name: str = None
1168+
mo_cli_arg_pipelines_dir: str = None
1169+
mo_cli_arg_with_test_identifiers: bool = False
1170+
mo_cli_arg_pipeline: str = None
1171+
mo_query_var_profile: str = None
1172+
mo_cli_arg_profile: str = None
11731173
try:
1174-
mo_query_var_pipeline_name: str = cast(str, mo.query_params().get("pipeline")) or None
1175-
mo_cli_arg_pipeline: str = cast(str, mo.cli_args().get("pipeline")) or None
1176-
mo_cli_arg_pipelines_dir: str = cast(str, mo.cli_args().get("pipelines-dir")) or None
1177-
mo_cli_arg_with_test_identifiers: bool = (
1174+
mo_query_var_pipeline_name = cast(str, mo.query_params().get("pipeline")) or None
1175+
mo_cli_arg_pipeline = cast(str, mo.cli_args().get("pipeline")) or None
1176+
mo_cli_arg_pipelines_dir = cast(str, mo.cli_args().get("pipelines-dir")) or None
1177+
mo_cli_arg_with_test_identifiers = (
11781178
cast(bool, mo.cli_args().get("with_test_identifiers")) or False
11791179
)
11801180
mo_query_var_profile = (

0 commit comments

Comments
 (0)