fixes bug, where configs where not injected for async functions (#1241)

Author: sh-rp

dlt/common/reflection/utils.py

@@ -1,12 +1,12 @@
 import ast
 import inspect
 import astunparse
-from typing import Any, Dict, List, Optional, Sequence, Tuple
+from typing import Any, Dict, List, Optional, Sequence, Tuple, Union
 
 from dlt.common.typing import AnyFun
 
 
-def get_literal_defaults(node: ast.FunctionDef) -> Dict[str, str]:
+def get_literal_defaults(node: Union[ast.FunctionDef, ast.AsyncFunctionDef]) -> Dict[str, str]:
     """Extract defaults from function definition node literally, as pieces of source code"""
     defaults: List[ast.expr] = []
     if node.args.defaults:
@@ -30,12 +30,12 @@ def get_literal_defaults(node: ast.FunctionDef) -> Dict[str, str]:
     return literal_defaults
 
 
-def get_func_def_node(f: AnyFun) -> ast.FunctionDef:
+def get_func_def_node(f: AnyFun) -> Union[ast.FunctionDef, ast.AsyncFunctionDef]:
     """Finds the function definition node for function f by parsing the source code of the f's module"""
     source, lineno = inspect.findsource(inspect.unwrap(f))
 
     for node in ast.walk(ast.parse("".join(source))):
-        if isinstance(node, ast.FunctionDef):
+        if isinstance(node, ast.FunctionDef) or isinstance(node, ast.AsyncFunctionDef):
             f_lineno = node.lineno - 1
             # get line number of first decorator
             if node.decorator_list:

tests/common/reflection/test_reflect_spec.py

@@ -358,3 +358,23 @@ def _f_4(str_str=300, p_def: bool = True):
     assert SPEC.get_resolvable_fields()["str_str"] == int
     # default
     assert fields["str_str"] == 300
+
+
+def test_reflect_async_function() -> None:
+    async def _f_1_as(str_str: str = dlt.config.value, blah: bool = dlt.config.value):
+        import asyncio
+
+        await asyncio.sleep(1)
+
+    SPEC_AS, fields_as = spec_from_signature(_f_1_as, inspect.signature(_f_1_as), False)
+
+    def _f_1(str_str: str = dlt.config.value, blah: bool = dlt.config.value):
+        pass
+
+    SPEC, fields = spec_from_signature(_f_1, inspect.signature(_f_1), False)
+
+    # discovered fields are the same for sync and async functions
+    assert fields
+    assert fields == fields_as
+    assert len(SPEC.get_resolvable_fields()) == len(fields) == 2
+    assert SPEC.get_resolvable_fields() == SPEC_AS.get_resolvable_fields()