Commit 9e42cbd
authored
Jinso o fix/cors playground (#2995)
* Update playground.py
Replace REST demo with DummyJSON users (CORS-safe for Playground)
* update with actual use case
* feat: improve playground example with real API data
- Switch from dummyjson to JSONPlaceholder users API
- Add dev_mode=True for better development experience
- Fix function parameter (remove unused dlt parameter)
- Update table references from 'items' to 'users' consistently
- Fix test assertion to expect 10 users instead of 50
- Add write_disposition='replace' to prevent data duplication
- Improve data display with proper return statements
* feat(playground): make pipeline idempotent with refresh=True
* fix: remove problematic sqlite3 micropip install causing linting failure
* lint: ruff fix & format playground notebook
* Playground: updated assert
* feat: add improved Marimo with better optimization and formatting
* code edit : removed argument refresh to avoid users confusion
* feat: update playground to use customers pipeline
- Changed from users API (jsonplaceholder) to customers API (jaffle-shop)
- Updated resource name from 'users' to 'customers'
- Updated pipeline name from 'users_pipeline' to 'customers_pipeline'
- Updated all table references and test assertions
- Improved response handling with proper yield from pattern
* fix: resolve linting issues in playground notebook
- Fixed unused marimo import (auto-removed by ruff)
- Fixed unused variable 'con' by returning it from connect function
- Applied proper code formatting with ruff
- All tests pass locally
* Address review feedback: update yield and add limit parameter
- Change 'yield from response.json()' to 'yield response.json()' as requested by reviewer
- Add ?limit=100 parameter to API call for consistent results
- Update assertion to expect exactly 100 customers (== 100)
- Addresses feedback from AstrakhantsevaAA in PR #29951 parent 4af60c8 commit 9e42cbd
1 file changed
+11
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
| |||
28 | 27 | | |
29 | 28 | | |
30 | 29 | | |
31 | | - | |
32 | | - | |
33 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
| 42 | + | |
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
47 | | - | |
48 | | - | |
| 48 | + | |
| 49 | + | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
56 | | - | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
62 | | - | |
| 63 | + | |
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
| |||
0 commit comments