Fix "re-tagging bug" by abusing docker build to multi-tag a single-line synthetic Dockerfile

Author: tianon

cmd/bashbrew/cmd-build.go

@@ -2,6 +2,7 @@ package main
 
 import (
 	"fmt"
+	"strings"
 
 	"github.com/urfave/cli"
 )
@@ -132,6 +133,15 @@ func cmdBuild(c *cli.Context) error {
 				}
 			} else {
 				fmt.Printf("Using %s (%s)\n", cacheTag, r.EntryIdentifier(entry))
+
+				if !dryRun {
+					// https://github.com/docker-library/bashbrew/pull/61/files#r1044926620
+					// abusing "docker build" for "tag something a lot of times, but efficiently" 👀
+					err := dockerBuild(imageTags, "", strings.NewReader("FROM "+cacheTag), "")
+					if err != nil {
+						return cli.NewMultiError(fmt.Errorf(`failed tagging %q: %q`, cacheTag, strings.Join(imageTags, ", ")), err)
+					}
+				}
 			}
 		}
 	}

cmd/bashbrew/docker.go

@@ -255,7 +255,10 @@ func dockerBuild(tags []string, file string, context io.Reader, platform string)
 	for _, tag := range tags {
 		args = append(args, "--tag", tag)
 	}
-	args = append(args, "--file", file, "--rm", "--force-rm", "-")
+	if file != "" {
+		args = append(args, "--file", file)
+	}
+	args = append(args, "--rm", "--force-rm", "-")
 
 	cmd := exec.Command("docker", args...)
 	cmd.Env = append(os.Environ(), "DOCKER_BUILDKIT=0")