Skip to content

Hello-world copy still advertises Docker cloud #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pvj opened this issue Mar 28, 2018 · 3 comments
Closed

Hello-world copy still advertises Docker cloud #45

pvj opened this issue Mar 28, 2018 · 3 comments

Comments

@pvj
Copy link

pvj commented Mar 28, 2018 •
edited
Loading

During testing an environment w/ your image I noticed Docker cloud is still advertised in the copy.

Share images, automate workflows, and more with a free Docker ID: https://cloud.docker.com/

As the service will be shut down perhaps this should be removed and/or changed?

Let me know if it's OK to open a PR that removes these. Cheers.
@tianon
Copy link
Member

tianon commented Mar 28, 2018

Oh, good point!

@chanezon @j0hnst0n what should we update this to point to? Back to Hub again?

@surfkansas surfkansas mentioned this issue Mar 29, 2018
Merged
@chanezon
Copy link
Contributor

yes

@tianon
Copy link
Member

tianon commented May 7, 2018

Fixed via #46. 👍

@tianon tianon closed this as completed May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chanezon @tianon @pvj