Skip to content

Use a newer version of setuptools for pypy3 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
olliemath opened this issue Sep 13, 2021 · 3 comments · Fixed by #63
Closed

Use a newer version of setuptools for pypy3 #62

olliemath opened this issue Sep 13, 2021 · 3 comments · Fixed by #63

Comments

@olliemath
Copy link

olliemath commented Sep 13, 2021

#61 managed to break our images in subtle ways with issues at runtime (rather than install) - I'm unsure how to upstream this as the exact issue is hard to pin down (see below image).

The fix was to revert back to the python3.7 version of setuptools. This should be the default, rather than supporting pypy 2.7 by using setuptools 44.x in the 3.7 image.

image

@tianon
Copy link
Member

tianon commented Sep 13, 2021

I was afraid of this. 😞

I suppose we should mirror docker-library/python#647 and look at https://foss.heptapod.net/pypy/pypy/-/blob/release-pypy2.7-v7.3.5/lib-python/2.7/ensurepip/__init__.py vs https://foss.heptapod.net/pypy/pypy/-/blob/release-pypy3.7-v7.3.5/lib-python/3/ensurepip/__init__.py

Concretely, that would mean:

  • 2.7: pip 20.0.x + setuptools 44.0.x
  • 3.7: pip 20.1.x + setuptools 47.1.x

@tianon
Copy link
Member

tianon commented Sep 13, 2021

I've got a proposal up in #63 that avoids us scraping/choosing versions at all (and instead trusting pypy to choose the appropriate versions).

@olliemath
Copy link
Author

Thanks, that seems sensible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants