Skip to content

Commit 5899357

Browse files
authored
Merge pull request #304 from JayH5/nis-modules-patch-update
update.sh: Fix nis library condition
2 parents 425379c + 28a2296 commit 5899357

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

3.4/alpine3.7/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,8 @@ RUN set -ex \
4646
gdbm-dev \
4747
libc-dev \
4848
libffi-dev \
49-
libnsl-dev \
5049
libressl \
5150
libressl-dev \
52-
libtirpc-dev \
5351
linux-headers \
5452
make \
5553
ncurses-dev \

3.5/alpine3.7/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,8 @@ RUN set -ex \
4646
gdbm-dev \
4747
libc-dev \
4848
libffi-dev \
49-
libnsl-dev \
5049
libressl \
5150
libressl-dev \
52-
libtirpc-dev \
5351
linux-headers \
5452
make \
5553
ncurses-dev \

update.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,10 @@ for version in "${versions[@]}"; do
159159
sed -ri -e 's/libressl/openssl/g' "$dir/Dockerfile"
160160
fi
161161

162-
# Libraries to build the nis module available in Alpine 3.7, but also require this patch:
163-
# https://bugs.python.org/issue32521
164-
if [[ "$variant" == alpine* ]] && [[ "$variant" != alpine3.7 ]]; then
162+
# Libraries to build the nis module only available in Alpine 3.7+.
163+
# Also require this patch https://bugs.python.org/issue32521 only available in Python 2.7, 3.6+.
164+
if [[ "$variant" == alpine* ]] && [[ "$version" == 3.4* || "$version" == 3.5* ]] \
165+
|| [[ "$variant" == alpine3.6 ]]; then
165166
sed -ri -e '/libnsl-dev/d' -e '/libtirpc-dev/d' "$dir/Dockerfile"
166167
fi
167168

0 commit comments

Comments
 (0)