cli/compose/types: ServiceVolumeConfig: use strong type for Consistency field

Using a strong type for this field, to make it clearer what's supported,
and to allow assigning values without having to cast them.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Author: thaJeztah

cli/compose/convert/volume.go

@@ -30,7 +30,7 @@ func createMountFromVolume(volume composetypes.ServiceVolumeConfig) mount.Mount
 		Target:      volume.Target,
 		ReadOnly:    volume.ReadOnly,
 		Source:      volume.Source,
-		Consistency: mount.Consistency(volume.Consistency),
+		Consistency: volume.Consistency,
 	}
 }
 

internal/volumespec/types.go

@@ -4,16 +4,16 @@ import "github.com/moby/moby/api/types/mount"
 
 // VolumeConfig are references to a volume used by a service
 type VolumeConfig struct {
-	Type        mount.Type   `yaml:",omitempty" json:"type,omitempty"`
-	Source      string       `yaml:",omitempty" json:"source,omitempty"`
-	Target      string       `yaml:",omitempty" json:"target,omitempty"`
-	ReadOnly    bool         `mapstructure:"read_only" yaml:"read_only,omitempty" json:"read_only,omitempty"`
-	Consistency string       `yaml:",omitempty" json:"consistency,omitempty"`
-	Bind        *BindOpts    `yaml:",omitempty" json:"bind,omitempty"`
-	Volume      *VolumeOpts  `yaml:",omitempty" json:"volume,omitempty"`
-	Image       *ImageOpts   `yaml:",omitempty" json:"image,omitempty"`
-	Tmpfs       *TmpFsOpts   `yaml:",omitempty" json:"tmpfs,omitempty"`
-	Cluster     *ClusterOpts `yaml:",omitempty" json:"cluster,omitempty"`
+	Type        mount.Type        `yaml:",omitempty" json:"type,omitempty"`
+	Source      string            `yaml:",omitempty" json:"source,omitempty"`
+	Target      string            `yaml:",omitempty" json:"target,omitempty"`
+	ReadOnly    bool              `mapstructure:"read_only" yaml:"read_only,omitempty" json:"read_only,omitempty"`
+	Consistency mount.Consistency `yaml:",omitempty" json:"consistency,omitempty"`
+	Bind        *BindOpts         `yaml:",omitempty" json:"bind,omitempty"`
+	Volume      *VolumeOpts       `yaml:",omitempty" json:"volume,omitempty"`
+	Image       *ImageOpts        `yaml:",omitempty" json:"image,omitempty"`
+	Tmpfs       *TmpFsOpts        `yaml:",omitempty" json:"tmpfs,omitempty"`
+	Cluster     *ClusterOpts      `yaml:",omitempty" json:"cluster,omitempty"`
 }
 
 // BindOpts are options for a service volume of type bind