Merge pull request #191 from crazy-max/fix-dl-release

use Octokit client to download buildx

Author: crazy-max

.github/workflows/test.yml

@@ -30,6 +30,8 @@ jobs:
         uses: docker/bake-action@v2
         with:
           targets: test
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       -
         name: Upload coverage
         uses: codecov/codecov-action@v3

__tests__/buildx.test.ts

@@ -221,7 +221,7 @@ describe('install', () => {
   ])(
     'acquires %p of buildx (standalone: %p)',
     async (version, standalone) => {
-      const buildxBin = await buildx.install(version, tmpDir, standalone);
+      const buildxBin = await buildx.install(version, process.env.GITHUB_TOKEN || '', tmpDir, standalone);
       expect(fs.existsSync(buildxBin)).toBe(true);
     },
     100000

__tests__/github.test.ts

@@ -3,14 +3,18 @@ import * as github from '../src/github';
 
 describe('github', () => {
   it('returns latest buildx GitHub release', async () => {
-    const release = await github.getRelease('latest');
+    const release = await github.getLatestRelease(process.env.GITHUB_TOKEN || '');
     expect(release).not.toBeNull();
     expect(release?.tag_name).not.toEqual('');
   });
 
   it('returns v0.2.2 buildx GitHub release', async () => {
-    const release = await github.getRelease('v0.2.2');
+    const release = await github.getReleaseTag('v0.2.2', process.env.GITHUB_TOKEN || '');
     expect(release).not.toBeNull();
     expect(release?.tag_name).toEqual('v0.2.2');
   });
+
+  it('unknown release', async () => {
+    await expect(github.getReleaseTag('foo', process.env.GITHUB_TOKEN || '')).rejects.toThrowError(new Error('Cannot get release foo: HttpError: Not Found'));
+  });
 });

action.yml

@@ -44,6 +44,10 @@ inputs:
   append:
     description: 'Append additional nodes to the builder'
     required: false
+  github_token:
+    description: 'The GitHub token used to create an authenticated client for GitHub API'
+    default: ${{ github.token }}
+    required: false
 
 outputs:
   name:

dev.Dockerfile

@@ -72,7 +72,8 @@ RUN --mount=type=bind,target=.,rw \
   --mount=type=cache,target=/src/node_modules \
   --mount=type=bind,from=docker,source=/usr/local/bin/docker,target=/usr/bin/docker \
   --mount=type=bind,from=buildx,source=/buildx,target=/usr/libexec/docker/cli-plugins/docker-buildx \
-  yarn run test --coverageDirectory=/tmp/coverage
+  --mount=type=secret,id=GITHUB_TOKEN \
+  GITHUB_TOKEN=$(cat /run/secrets/GITHUB_TOKEN) yarn run test --coverageDirectory=/tmp/coverage
 
 FROM scratch AS test-coverage
 COPY --from=test /tmp/coverage /

dist/index.js

@@ -50,4 +50,5 @@ target "test" {
   dockerfile = "dev.Dockerfile"
   target = "test-coverage"
   output = ["./coverage"]
+  secret = ["id=GITHUB_TOKEN,env=GITHUB_TOKEN"]
 }

dist/index.js.map

@@ -29,7 +29,7 @@
   "dependencies": {
     "@actions/core": "^1.10.0",
     "@actions/exec": "^1.1.1",
-    "@actions/http-client": "^2.0.1",
+    "@actions/github": "^5.1.1",
     "@actions/tool-cache": "^2.0.1",
     "csv-parse": "^5.3.3",
     "js-yaml": "^4.1.0",