Skip to content

feat: add initial rule-based model to identify ListItem markers #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 20, 2025
Merged

feat: add initial rule-based model to identify ListItem markers #113

merged 6 commits into from
Jun 20, 2025
+372 −4

Conversation

PeterStaar-IBM
Copy link
Contributor

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

@PeterStaar-IBM PeterStaar-IBM self-assigned this Jun 17, 2025
@mergify Mergify
Copy link

mergify bot commented Jun 17, 2025 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025 •
edited
Loading

✅ DCO Check Passed

Thanks @PeterStaar-IBM, all your commits are properly signed off. 🎉

@PeterStaar-IBM PeterStaar-IBM marked this pull request as ready for review June 17, 2025 11:37
cau-git
cau-git previously approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@cau-git cau-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PeterStaar-IBM PeterStaar-IBM requested a review from vagenas June 20, 2025 08:29
@vagenas
minor renamings
9cac015 
Signed-off-by: Panos Vagenas <[email protected]>
@vagenas vagenas changed the title initial rb model to identify listitem markers feat: add initial rule-based model to identify ListItem markers Jun 20, 2025
cau-git
cau-git approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@cau-git cau-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cau-git cau-git merged commit e063b97 into main Jun 20, 2025
11 checks passed
@cau-git cau-git deleted the dev/add-listitem-marker-identifier branch June 20, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagenas vagenas vagenas approved these changes

@cau-git cau-git cau-git approved these changes

@dolfim-ibm dolfim-ibm Awaiting requested review from dolfim-ibm

Assignees

@PeterStaar-IBM PeterStaar-IBM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeterStaar-IBM @vagenas @cau-git