Skip to content

Respect externalLinkTarget for GitHub Corner #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
gluons opened this issue May 7, 2019 · 0 comments
Closed
1 task done

Respect externalLinkTarget for GitHub Corner #835

gluons opened this issue May 7, 2019 · 0 comments

Comments

@gluons
Copy link

gluons commented May 7, 2019

Bug Report

Link target of repo's GitHub Corner should respect externalLinkTarget config.

Steps to reproduce

Set repo config and click GitHub Corner link.

What is current behaviour

Open repo in current window/tab.

What is the expected behaviour

Open repo in new window/tab by default.
(Because default value of externalLinkTarget is _blank)

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: Windows 10

  • Node.js version: v10.15.3

  • npm/yarn version: npm v6.9.0, Yarn v1.15.2

  • Browser version: Firefox (Dev Edition) 67.0b15

  • Docsify version: 4.9.4

  • Docsify plugins: -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant