Skip to content

Commit 6f97117

Browse files
committed
fix review comments
1 parent e27996e commit 6f97117

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

src/Aggregation/Expr.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,8 +241,6 @@ public function cond(mixed $if, mixed $then, mixed $else): static
241241
* are returned directly.
242242
*
243243
* @internal
244-
*
245-
* @return string|array<string, mixed>
246244
*/
247245
public static function convertExpression(mixed $expression): mixed
248246
{

src/Aggregation/Stage/Operator.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -471,14 +471,14 @@ public function indexOfArray(mixed $arrayExpression, mixed $searchExpression, mi
471471
return $this;
472472
}
473473

474-
public function indexOfBytes(mixed $stringExpression, mixed $substringExpression, mixed $start = null, mixed $end = null): static
474+
public function indexOfBytes(mixed $stringExpression, mixed $substringExpression, string|int|null $start = null, string|int|null $end = null): static
475475
{
476476
$this->expr->indexOfBytes(...func_get_args());
477477

478478
return $this;
479479
}
480480

481-
public function indexOfCP(mixed $stringExpression, mixed $substringExpression, mixed $start = null, mixed $end = null): static
481+
public function indexOfCP(mixed $stringExpression, mixed $substringExpression, string|int|null $start = null, string|int|null $end = null): static
482482
{
483483
$this->expr->indexOfCP(...func_get_args());
484484

@@ -597,7 +597,7 @@ public function ltrim(mixed $input, mixed $chars = null): static
597597
return $this;
598598
}
599599

600-
public function map(mixed $input, mixed $as, mixed $in): static
600+
public function map(mixed $input, string $as, mixed $in): static
601601
{
602602
$this->expr->map(...func_get_args());
603603

@@ -730,21 +730,21 @@ public function reduce(mixed $input, mixed $initialValue, mixed $in): static
730730
return $this;
731731
}
732732

733-
public function regexFind(mixed $input, mixed $regex, mixed $options = null): static
733+
public function regexFind(mixed $input, mixed $regex, ?string $options = null): static
734734
{
735735
$this->expr->regexFind(...func_get_args());
736736

737737
return $this;
738738
}
739739

740-
public function regexFindAll(mixed $input, mixed $regex, mixed $options = null): static
740+
public function regexFindAll(mixed $input, mixed $regex, ?string $options = null): static
741741
{
742742
$this->expr->regexFindAll(...func_get_args());
743743

744744
return $this;
745745
}
746746

747-
public function regexMatch(mixed $input, mixed $regex, mixed $options = null): static
747+
public function regexMatch(mixed $input, mixed $regex, ?string $options = null): static
748748
{
749749
$this->expr->regexMatch(...func_get_args());
750750

0 commit comments

Comments
 (0)