Skip to content

Example given for factory-based middleware could have been clearer #6833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sateesh-pagolu opened this issue Jun 3, 2018 — with docs.microsoft.com · 6 comments
Closed
Labels
Pri3 Source - Docs.ms Docs Customer feedback via GitHub Issue
Milestone

Comments

Copy link

sateesh-pagolu commented Jun 3, 2018

The current example given in the documentation of factory-based middleware is not very clear. A real-time use case with more clear example would have been much helpful.
Same is the case with "Middleware activation with a third-party container".

Any link to other examples/documentation elsewhere will be much appreciated.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@sateesh-pagolu sateesh-pagolu changed the title Example for factory-based middleware given could have been clearer Example given for factory-based middleware could have been clearer Jun 3, 2018
@guardrex guardrex added the Source - Docs.ms Docs Customer feedback via GitHub Issue label Jun 3, 2018
@guardrex
Copy link
Collaborator

guardrex commented Jun 3, 2018

Hello and thanks for the feedback @5a7335h. The sample does show a real-world use case: the database context used in the sample is a scoped service. Can you elaborate on what you find confusing?

@guardrex
Copy link
Collaborator

guardrex commented Jun 3, 2018

Both topics don't focus on real-world middleware implementations ... they focus on middleware activation patterns. If you would like to see real-world middleware examples, your best bet is to search broadly for blog posts and GH repo examples.

Any link to other examples/documentation elsewhere will be much appreciated.

Yes, that's possible. We'd probably do that in the main middleware topic.

@guardrex guardrex added the Pri3 label Jun 3, 2018
@guardrex guardrex added this to the Backlog milestone Jun 3, 2018
@sateesh-pagolu
Copy link
Author

sateesh-pagolu commented Jun 4, 2018

Thanks for your super fast response @guardrex. 👍
This discussion has clarified few things. Although the examples given in the documentation show the implementation of this concept, I was actually looking for a basic example that emphasizes the benefit of using IMiddleware and IMiddlewareFactory (Scoping for example?). I started looking for the blog posts to see more specific scenarios. I might find one soon. But thought I would share the feedback so that we would have more authentic example in MSDN docs.

Copy link

Personally I find the class name IMiddlewareMiddleware jarring, since it looks like the name of an Interface not a class.

@guardrex
Copy link
Collaborator

I'd like to change the name to "FactoryActivatedMiddleware."

@Rick-Anderson
Copy link
Contributor

Thanks for contacting us.
We don’t have the resources to invest in this area, so we are closing the issue. Should your request generate enough 👍 responses, we’ll reconsider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pri3 Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
None yet
Development

No branches or pull requests

4 participants