review: use string.Replace instead of for loop

Author: davidelettieri

sources/ClangSharp.PInvokeGenerator/CSharp/CSharpOutputBuilder.cs

@@ -130,21 +130,7 @@ public void WriteLabel(string name)
         WriteLine(':');
     }
 
-    public void WriteNumberLiteral(ReadOnlySpan<char> value)
-    {
-        for (var i = 0; i < value.Length; i++)
-        {
-            var c = value[i];
-            if (c == '\'')
-            {
-                Write('_');
-            }
-            else
-            {
-                Write(c);
-            }
-        }
-    }
+    public void WriteNumberLiteral(string value) => Write(value.Replace('\'', '_'));
 
     public void WriteLine<T>(T value)
     {

sources/ClangSharp.PInvokeGenerator/PInvokeGenerator.VisitStmt.cs

@@ -1201,7 +1201,7 @@ private void VisitFloatingLiteral(FloatingLiteral floatingLiteral)
         var outputBuilder = StartCSharpCode();
         if (floatingLiteral.ValueString.EndsWith(".f", StringComparison.Ordinal))
         {
-            outputBuilder.WriteNumberLiteral(floatingLiteral.ValueString.AsSpan()[..^1]);
+            outputBuilder.WriteNumberLiteral(floatingLiteral.ValueString[..^1]);
             outputBuilder.Write("0f");
         }
         else
@@ -1994,7 +1994,7 @@ void HandleUnmanagedConstant(CSharpOutputBuilder outputBuilder, InitListExpr ini
 
     private void VisitIntegerLiteral(IntegerLiteral integerLiteral)
     {
-        var valueString = integerLiteral.ValueString.AsSpan();
+        var valueString = integerLiteral.ValueString;
         var valueSuffix = "";
 
         if (valueString.EndsWith("ui8", StringComparison.OrdinalIgnoreCase))