Cleanup | Remove SmiEventSink_Default (#3438)

* Stage 1: _errors and _warnings are always null, so HasMessages will always be false

* Initial cleanup of ProcessMessages and ProcessMessagesAndThrow

* Stub now-empty methods

* Remove ProcessMessagesAndThrow (and all references.)

* Remove first pass of SmiEventSink_Default parameters

* Complete removal of SmiEventSink_Default from setters

* Remove SmiEventSink_Default from SmiGettersStream, follow through

* Remove circular references from GetValue and GetSqlValue200

* Remove unused SmiEventSink_Default parameters, follow through

* Remove lingering SmiEventSink_Default file

* Clean up _recordBuffer assignment

Author: edwardneal

src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj

@@ -423,9 +423,6 @@
     <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\MetadataUtilsSmi.cs">
       <Link>Microsoft\Data\SqlClient\Server\MetadataUtilsSmi.cs</Link>
     </Compile>
-    <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiEventSink_Default.cs">
-      <Link>Microsoft\Data\SqlClient\Server\SmiEventSink_Default.cs</Link>
-    </Compile>
     <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiGettersStream.cs">
       <Link>Microsoft\Data\SqlClient\Server\SmiGettersStream.cs</Link>
     </Compile>

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs

@@ -10366,7 +10366,6 @@ private void WriteSmiParameter(SqlParameter param, int paramIndex, bool sendDefa
             //
             TdsParameterSetter paramSetter = new TdsParameterSetter(stateObj, metaData);
             ValueUtilsSmi.SetCompatibleValueV200(
-                                        new SmiEventSink_Default(),  // TDS Errors/events dealt with at lower level for now, just need an object for processing
                                         paramSetter,
                                         0,          // ordinal.  TdsParameterSetter only handles one parameter at a time
                                         metaData,

src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj

@@ -534,9 +534,6 @@
     <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\MetadataUtilsSmi.cs">
       <Link>Microsoft\Data\SqlClient\Server\MetadataUtilsSmi.cs</Link>
     </Compile>
-    <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiEventSink_Default.cs">
-      <Link>Microsoft\Data\SqlClient\Server\SmiEventSink_Default.cs</Link>
-    </Compile>
     <Compile Include="$(CommonSourceRoot)Microsoft\Data\SqlClient\Server\SmiGettersStream.cs">
       <Link>Microsoft\Data\SqlClient\Server\SmiGettersStream.cs</Link>
     </Compile>

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs

@@ -10558,7 +10558,6 @@ private void WriteSmiParameter(SqlParameter param, int paramIndex, bool sendDefa
             //
             TdsParameterSetter paramSetter = new TdsParameterSetter(stateObj, metaData);
             ValueUtilsSmi.SetCompatibleValueV200(
-                                        new SmiEventSink_Default(),  // TDS Errors/events dealt with at lower level for now, just need an object for processing
                                         paramSetter,
                                         0,          // ordinal.  TdsParameterSetter only handles one parameter at a time
                                         metaData,

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/SmiEventSink_Default.cs

@@ -9,20 +9,17 @@ namespace Microsoft.Data.SqlClient.Server
 {
     internal class SmiGettersStream : Stream
     {
-        private SmiEventSink_Default _sink;
         private ITypedGettersV3 _getters;
         private int _ordinal;
         private long _readPosition;
         private SmiMetaData _metaData;
 
-        internal SmiGettersStream(SmiEventSink_Default sink, ITypedGettersV3 getters, int ordinal, SmiMetaData metaData)
+        internal SmiGettersStream(ITypedGettersV3 getters, int ordinal, SmiMetaData metaData)
         {
-            Debug.Assert(sink != null);
             Debug.Assert(getters != null);
             Debug.Assert(0 <= ordinal);
             Debug.Assert(metaData != null);
 
-            _sink = sink;
             _getters = getters;
             _ordinal = ordinal;
             _readPosition = 0;
@@ -58,7 +55,7 @@ public override long Length
         {
             get
             {
-                return ValueUtilsSmi.GetBytesInternal(_sink, _getters, _ordinal, _metaData, 0, null, 0, 0, false);
+                return ValueUtilsSmi.GetBytesInternal(_getters, _ordinal, _metaData, 0, null, 0, 0, false);
             }
         }
 
@@ -91,7 +88,7 @@ public override void SetLength(long value)
 
         public override int Read(byte[] buffer, int offset, int count)
         {
-            long bytesRead = ValueUtilsSmi.GetBytesInternal(_sink, _getters, _ordinal, _metaData, _readPosition, buffer, offset, count, false);
+            long bytesRead = ValueUtilsSmi.GetBytesInternal(_getters, _ordinal, _metaData, _readPosition, buffer, offset, count, false);
             _readPosition += bytesRead;
 
             return checked((int)bytesRead);

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/SmiGettersStream.cs

@@ -10,20 +10,17 @@ namespace Microsoft.Data.SqlClient.Server
 {
     internal class SmiSettersStream : Stream
     {
-        private SmiEventSink_Default _sink;
         private ITypedSettersV3 _setters;
         private int _ordinal;
         private long _lengthWritten;
         private SmiMetaData _metaData;
 
-        internal SmiSettersStream(SmiEventSink_Default sink, ITypedSettersV3 setters, int ordinal, SmiMetaData metaData)
+        internal SmiSettersStream(ITypedSettersV3 setters, int ordinal, SmiMetaData metaData)
         {
-            Debug.Assert(sink != null);
             Debug.Assert(setters != null);
             Debug.Assert(0 <= ordinal);
             Debug.Assert(metaData != null);
 
-            _sink = sink;
             _setters = setters;
             _ordinal = ordinal;
             _lengthWritten = 0;
@@ -77,7 +74,7 @@ public override long Position
 
         public override void Flush()
         {
-            _lengthWritten = ValueUtilsSmi.SetBytesLength(_sink, _setters, _ordinal, _metaData, _lengthWritten);
+            _lengthWritten = ValueUtilsSmi.SetBytesLength(_setters, _ordinal, _metaData, _lengthWritten);
         }
 
         public override long Seek(long offset, SeekOrigin origin)
@@ -91,7 +88,7 @@ public override void SetLength(long value)
             {
                 throw ADP.ArgumentOutOfRange(nameof(value));
             }
-            ValueUtilsSmi.SetBytesLength(_sink, _setters, _ordinal, _metaData, value);
+            ValueUtilsSmi.SetBytesLength(_setters, _ordinal, _metaData, value);
         }
 
         public override int Read(byte[] buffer, int offset, int count)
@@ -101,7 +98,7 @@ public override int Read(byte[] buffer, int offset, int count)
 
         public override void Write(byte[] buffer, int offset, int count)
         {
-            _lengthWritten += ValueUtilsSmi.SetBytes(_sink, _setters, _ordinal, _metaData, _lengthWritten, buffer, offset, count);
+            _lengthWritten += ValueUtilsSmi.SetBytes(_setters, _ordinal, _metaData, _lengthWritten, buffer, offset, count);
         }
     }
 }