Tests | Move various unit tests to UnitTests project (#3458)

* Move SqlVectorTest, adjust namespace

* Replace LocalAppContextSwitchesTests

* Move SqlBufferTests

* Remove unnecessary reflection from SqlBufferTests

* Add descriptions to SqlBufferTests

* Move SqlCommandSetTest

* Remove unnecessary reflection from SqlCommandSetTest

* Act on messages

* Add descriptions to SqlCommandSetTests

* Rename SqlBufferTests to align with standard

* Adhere to project code style: namespace statements

* Remove redundant using statement

* Add missing license statement

* Remove all internal reflection on SqlCommandSetTest

* Remove unnecessary validation logic (and covering test)

Author: edwardneal

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommandSet.cs

@@ -30,7 +30,7 @@ internal SqlCommandSet() : base()
             _commandList = new List<SqlBatchCommand>();
         }
 
-        private SqlCommand BatchCommand
+        internal SqlCommand BatchCommand
         {
             get
             {
@@ -45,7 +45,7 @@ private SqlCommand BatchCommand
 
         internal int CommandCount => CommandList.Count;
 
-        private List<SqlBatchCommand> CommandList
+        internal List<SqlBatchCommand> CommandList
         {
             get
             {
@@ -98,24 +98,16 @@ internal void Append(SqlCommand command)
         {
             ADP.CheckArgumentNull(command, nameof(command));
             SqlClientEventSource.Log.TryTraceEvent("SqlCommandSet.Append | API | Object Id {0}, Command '{1}', Parameter Count {2}", ObjectID, command.ObjectID, command.Parameters.Count);
+
+            // SqlCommandSet only supports commands of type Text or StoredProcedure. This aligns with SqlCommand (validated by its CommandType setter.)
+            Debug.Assert(command.CommandType is CommandType.Text or CommandType.StoredProcedure);
+
             string cmdText = command.CommandText;
             if (string.IsNullOrEmpty(cmdText))
             {
                 throw ADP.CommandTextRequired(nameof(Append));
             }
 
-            CommandType commandType = command.CommandType;
-            switch (commandType)
-            {
-                case CommandType.Text:
-                case CommandType.StoredProcedure:
-                    break;
-                case CommandType.TableDirect:
-                    throw SQL.NotSupportedCommandType(commandType);
-                default:
-                    throw ADP.InvalidCommandType(commandType);
-            }
-
             SqlParameterCollection parameters = null;
 
             SqlParameterCollection collection = command.Parameters;
@@ -279,7 +271,7 @@ internal bool GetBatchedAffected(int commandIdentifier, out int recordsAffected,
         internal int GetParameterCount(int commandIndex)
             => CommandList[commandIndex].Parameters.Count;
 
-        private void ValidateCommandBehavior(string method, CommandBehavior behavior)
+        internal void ValidateCommandBehavior(string method, CommandBehavior behavior)
         {
             if (0 != (behavior & ~(CommandBehavior.SequentialAccess | CommandBehavior.CloseConnection)))
             {

src/Microsoft.Data.SqlClient/tests/FunctionalTests/LocalAppContextSwitchesTests.cs

@@ -30,10 +30,7 @@
     <Compile Include="MultipartIdentifierTests.cs" />
     <Compile Include="MultiplexerTests.cs" />
     <Compile Include="SqlAuthenticationProviderTest.cs" />
-    <Compile Include="SqlBufferTests.cs" />
     <Compile Include="SqlClientLoggerTest.cs" />
-    <Compile Include="SqlCommandSetTest.cs" />
-    <Compile Include="LocalAppContextSwitchesTests.cs" />
     <Compile Include="SqlConfigurableRetryLogicTest.cs" />
     <Compile Include="SqlCommandBuilderTest.cs" />
     <Compile Include="SqlBulkCopyTest.cs" />