Skip to content

Commit 0449d24

Browse files
committed
[tests] Fix network interface tests for Android 30
Context: https://developer.android.com/preview/behavior-changes-11#netlink-mac Context: https://developer.android.com/reference/java/net/NetworkInterface#getNetworkInterfaces() If an application targets `Android 11`/`API 30` (and newer) then the number of reported interfaces as well as the amount of information about them change to include less detail. First of all, only interfaces with associated IP addresses will be reported by both the `NetworkInterface` Java API and the `getifaddrs(3)` native libc API: * Application targetting API 28 on API 30 device: * name: wlan0; type: Ethernet * name: dummy0; type: Ethernet * name: lo; type: Loopback * name: hwsim0; type: Unknown * name: ip6tnl0; type: Tunnel * name: sit0; type: Tunnel * name: ip6_vti0; type: Tunnel * name: ip_vti0; type: Tunnel * Application targetting API 30 on API 30 device: * name: wlan0; type: 0 * name: dummy0; type: 0 * name: lo; type: 0 Second of all, as can be seen above, device information does not include the type of interface. This bit of information is what the `DotNetInterfacesShouldEqualJavaInterfaces` test relied on so far. That change broke our `DotNetInterfacesShouldEqualJavaInterfaces` test: DotNetInterfacesShouldEqualJavaInterfaces Mono interfaces: [InterfaceInfo: Name=radio0, IsLoopback=False, IsUp=True, HardwareAddress=<>, Addresses=<fe80::d4d9:5aff:fe48:60be%11, fec0::d4d9:5aff:fe48:60be, fec0::397c:d582:6278:ca2c, 10.0.2.15>] [InterfaceInfo: Name=wlan0, IsLoopback=False, IsUp=True, HardwareAddress=<>, Addresses=<fe80::e00a:8bb6:415b:4c97%9, fec0::f925:950b:4c31:eea7, fec0::315a:4cc4:796:6915, 10.0.2.16>] [InterfaceInfo: Name=dummy0, IsLoopback=False, IsUp=True, HardwareAddress=<>, Addresses=<fe80::4c41:86ff:fe93:6354%2>] [InterfaceInfo: Name=lo, IsLoopback=False, IsUp=True, HardwareAddress=<>, Addresses=<::1, 127.0.0.1>] Java interfaces: [InterfaceInfo: Name=dummy0, IsLoopback=False, IsUp=True, HardwareAddress=<>, Addresses=<fe80::4c41:86ff:fe93:6354%2>] [InterfaceInfo: Name=wlan0, IsLoopback=False, IsUp=True, HardwareAddress=<>, Addresses=<fe80::e00a:8bb6:415b:4c97%9, fec0::f925:950b:4c31:eea7, fec0::315a:4cc4:796:6915, 10.0.2.16>] [InterfaceInfo: Name=lo, IsLoopback=True, IsUp=True, HardwareAddress=<>, Addresses=<::1, 127.0.0.1>] [InterfaceInfo: Name=radio0, IsLoopback=False, IsUp=True, HardwareAddress=<>, Addresses=<fe80::d4d9:5aff:fe48:60be%11, fec0::d4d9:5aff:fe48:60be, fec0::397c:d582:6278:ca2c, 10.0.2.15>] Interface radio0: passed Interface wlan0: passed Interface dummy0: passed [FAIL] : #8.3 (lo not found in Java interfaces) Expected: True But was: False at System.NetTests.NetworkInterfacesTest.DotNetInterfacesShouldEqualJavaInterfaces () [0x00152] in <c0e2a2f723184a6080f550609db0528d>:0 at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&) at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&) Note that both Java and Mono return the same number of interfaces, with the same names but the `lo` interface in Mono list is not marked as loopback (`IsLoopback=False`) while the corresponding Java entry reports the interface is a loopback. In order to account for the above Android changes, we now look not only at the hardware type but also at its name in order to determine whether the device is a loopback one or not.
1 parent 044bbe5 commit 0449d24

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/Mono.Android/Test/System.Net/NetworkInterfaces.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ bool IsInterfaceUp (MNetworkInterface inf)
170170

171171
default:
172172
// Android considers 'lo' to be always up
173-
return inf.NetworkInterfaceType == NetworkInterfaceType.Loopback;
173+
return IsLoopbackInterface (inf);
174174
}
175175
}
176176

@@ -188,9 +188,10 @@ byte[] GetHardwareAddress (MNetworkInterface inf)
188188
var ret = new List <InterfaceInfo> ();
189189

190190
foreach (MNetworkInterface inf in interfaces) {
191+
Console.WriteLine ($"inf: {inf} (name: {inf.Name}; type: {inf.NetworkInterfaceType})");
191192
ret.Add (new InterfaceInfo {
192193
Name = inf.Name,
193-
IsLoopback = inf.NetworkInterfaceType == NetworkInterfaceType.Loopback,
194+
IsLoopback = IsLoopbackInterface (inf),
194195
IsUp = IsInterfaceUp (inf),
195196
HardwareAddress = GetHardwareAddress (inf),
196197
Addresses = CollectAddresses (inf)
@@ -220,5 +221,12 @@ byte[] GetHardwareAddress (MNetworkInterface inf)
220221

221222
return ret;
222223
}
224+
225+
static bool IsLoopbackInterface (MNetworkInterface inf)
226+
{
227+
// Android 30 will not tell us the interface type if the app targets API 30, we need to look at the
228+
// name then.
229+
return inf.NetworkInterfaceType == NetworkInterfaceType.Loopback || String.Compare ("lo", inf.Name, StringComparison.OrdinalIgnoreCase) == 0;
230+
}
223231
}
224232
}

0 commit comments

Comments
 (0)