Skip to content

Commit 3269d04

Browse files
committed
Updatee based on feedback
1 parent 68ef6eb commit 3269d04

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/Xamarin.Android.Build.Tasks/Tasks/GenerateJavaStubs.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,6 @@ void Run (DirectoryAssemblyResolver res, bool useMarshalMethods)
271271

272272
using (var acw_map = MemoryStreamPool.Shared.CreateStreamWriter ()) {
273273
foreach (TypeDefinition type in javaTypes) {
274-
string mvid = type.Module.Mvid.ToString ();
275274
string managedKey = type.FullName.Replace ('/', '.');
276275
string javaKey = JavaNativeTypeManager.ToJniName (type, cache).Replace ('/', '.');
277276

@@ -283,15 +282,15 @@ void Run (DirectoryAssemblyResolver res, bool useMarshalMethods)
283282
TypeDefinition conflict;
284283
bool hasConflict = false;
285284
if (managed.TryGetValue (managedKey, out conflict)) {
286-
if (!conflict.Module.Mvid.Equals(mvid)) {
285+
if (!conflict.Module.Mvid.Equals(type.Module.Mvid)) {
287286
if (!managedConflicts.TryGetValue (managedKey, out var list))
288287
managedConflicts.Add (managedKey, list = new List<string> { conflict.GetPartialAssemblyName (cache) });
289288
list.Add (type.GetPartialAssemblyName (cache));
290289
}
291290
hasConflict = true;
292291
}
293292
if (java.TryGetValue (javaKey, out conflict)) {
294-
if (!conflict.Module.Mvid.Equals(mvid)) {
293+
if (!conflict.Module.Mvid.Equals(type.Module.Mvid)) {
295294
if (!javaConflicts.TryGetValue (javaKey, out var list))
296295
javaConflicts.Add (javaKey, list = new List<string> { conflict.GetAssemblyQualifiedName (cache) });
297296
list.Add (type.GetAssemblyQualifiedName (cache));

0 commit comments

Comments
 (0)