Commit 3d6a67a
committed
[nunit] build X.A.NUnitLite.dll with API level 19
- current NUnitLite was built with latest API level. that was
problematic, because it was referencing BaseBundle class, which is
only available in API >= 21, see
https://developer.android.com/reference/android/os/BaseBundle.html
- so instead of using latest API, we now build it with API 19. that's
the lowes API level we can use, because
src/Xamarin.Android.NUnitLite/Gui/Instrumentations/TestSuiteInstrumentation.cs
is using global::Android.OS.Environment.DirectoryDocuments which is
avalable in API level >= 19, see
https://developer.android.com/reference/android/os/Environment.html#DIRECTORY_DOCUMENTS
- also the X.A.Build.Tasks project reference is now conditional,
because it requires API level >= 24. it is OK, because we build it
in leeroy-all rule with latest API level and default build uses
latest API level too. the project reference itself is there to
ensure the build ordering, so we can safely make it conditional
- it fixes bugs #53418 and #538841 parent a08cd80 commit 3d6a67a
File tree
3 files changed
+9
-2
lines changed- build-tools/scripts
- src/Xamarin.Android.NUnitLite
- Gui/Instrumentations
3 files changed
+9
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
106 | 109 | | |
107 | 110 | | |
108 | 111 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
97 | 101 | | |
98 | 102 | | |
99 | 103 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
353 | 353 | | |
354 | 354 | | |
355 | 355 | | |
356 | | - | |
| 356 | + | |
357 | 357 | | |
358 | 358 | | |
359 | 359 | | |
| |||
0 commit comments