Skip to content

Commit 7a2d771

Browse files
committed
Add more file checks
1 parent c5d9a06 commit 7a2d771

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/Xamarin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Assets.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved.
2626
<!-- Assets build properties -->
2727
<PropertyGroup>
2828
<MonoAndroidAssetsDirIntermediate>$(IntermediateOutputPath)assets\</MonoAndroidAssetsDirIntermediate>
29-
<MonoAndroidAssetPacksDirIntermediate>$(IntermediateOutputPath)assetpacks\packs</MonoAndroidAssetPacksDirIntermediate>
29+
<MonoAndroidAssetPacksDirIntermediate>$(IntermediateOutputPath)assetpacks</MonoAndroidAssetPacksDirIntermediate>
3030
<MonoAndroidAssetsPrefix Condition="'$(MonoAndroidAssetsPrefix)' == ''">Assets</MonoAndroidAssetsPrefix>
3131
</PropertyGroup>
3232

src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AssetPackTests.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ public void BuildApplicationWithAssetPack ([Values (true, false)] bool isRelease
5151
// Check the final aab has the required feature files in it.
5252
var aab = Path.Combine (Root, appBuilder.ProjectDirectory,
5353
app.OutputPath, $"{app.PackageName}.aab");
54+
var asset3File = Path.Combine (Root, path, app.ProjectName,
55+
app.IntermediateOutputPath, "assetpacks", "assetpack1", "assets", "asset3.txt");
5456
using (var zip = ZipHelper.OpenZip (aab)) {
5557
Assert.IsTrue (zip.ContainsEntry ("base/assets/asset1.txt"), "aab should contain base/assets/asset1.txt");
5658
Assert.IsFalse (zip.ContainsEntry ("base/assets/asset2.txt"), "aab should not contain base/assets/asset2.txt");
@@ -67,14 +69,18 @@ public void BuildApplicationWithAssetPack ([Values (true, false)] bool isRelease
6769
appBuilder.Output.AssertTargetIsSkipped ("_CreateAssetPackManifests");
6870
appBuilder.Output.AssertTargetIsSkipped ("_BuildAssetPacks");
6971
appBuilder.Output.AssertTargetIsSkipped ("_GenerateAndroidAssetsDir");
72+
FileAssert.Exists (asset3File, $"file {asset3File} should exist.");
7073
asset3.TextContent = () => "Asset3 Updated";
7174
asset3.Timestamp = DateTime.UtcNow.AddSeconds(1);
7275
Assert.IsTrue (appBuilder.Build (app, doNotCleanupOnUpdate: true, saveProject: false), $"{app.ProjectName} should succeed");
7376
appBuilder.Output.AssertTargetIsNotSkipped ("_CreateAssetPackManifests");
7477
appBuilder.Output.AssertTargetIsNotSkipped ("_BuildAssetPacks");
7578
appBuilder.Output.AssertTargetIsNotSkipped ("_GenerateAndroidAssetsDir");
79+
FileAssert.Exists (asset3File, $"file {asset3File} should exist.");
80+
Assert.AreEqual (asset3.TextContent (), File.ReadAllText (asset3File), $"Contents of {asset3File} should have been updated.");
7681
app.OtherBuildItems.Remove (asset3);
7782
Assert.IsTrue (appBuilder.Build (app, doNotCleanupOnUpdate: true), $"{app.ProjectName} should succeed");
83+
FileAssert.DoesNotExist (asset3File, $"file {asset3File} should not exist.");
7884
using (var zip = ZipHelper.OpenZip (aab)) {
7985
Assert.IsTrue (zip.ContainsEntry ("base/assets/asset1.txt"), "aab should contain base/assets/asset1.txt");
8086
Assert.IsFalse (zip.ContainsEntry ("base/assets/asset2.txt"), "aab should not contain base/assets/asset2.txt");

0 commit comments

Comments
 (0)