Skip to content

Commit b3881ad

Browse files
Enable android-arm CoreCLR native pack
Assume the android-arm CoreCLR runtime pack is available and keep the PR wired end-to-end: native build, pack creation, and workload manifest all include android-arm CoreCLR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 87af6ee commit b3881ad

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

build-tools/scripts/Ndk.projitems.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<ApiLevelNonMono>$(AndroidNdkApiLevelNonMono_Arm)</ApiLevelNonMono>
2626
<AndroidRID>android-arm</AndroidRID>
2727
<SupportMonoVM>True</SupportMonoVM>
28-
<SupportCoreCLR>False</SupportCoreCLR>
28+
<SupportCoreCLR>True</SupportCoreCLR>
2929
<SupportNativeAOT>False</SupportNativeAOT>
3030
</AndroidSupportedTargetJitAbi>
3131

src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/WorkloadManifest.in.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"Microsoft.Android.Runtime.Mono.37.android-arm64",
1313
"Microsoft.Android.Runtime.Mono.37.android-x86",
1414
"Microsoft.Android.Runtime.Mono.37.android-x64",
15+
"Microsoft.Android.Runtime.CoreCLR.37.android-arm",
1516
"Microsoft.Android.Runtime.CoreCLR.37.android-arm64",
1617
"Microsoft.Android.Runtime.CoreCLR.37.android-x64",
1718
"Microsoft.Android.Runtime.NativeAOT.37.android-arm64",
@@ -78,6 +79,10 @@
7879
"kind": "framework",
7980
"version": "@WORKLOAD_VERSION@"
8081
},
82+
"Microsoft.Android.Runtime.CoreCLR.37.android-arm": {
83+
"kind": "framework",
84+
"version": "@WORKLOAD_VERSION@"
85+
},
8186
"Microsoft.Android.Runtime.CoreCLR.37.android-arm64": {
8287
"kind": "framework",
8388
"version": "@WORKLOAD_VERSION@"

src/native/native-clr.csproj

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,8 @@
77
<OutputType>Exe</OutputType>
88
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
99

10-
<!-- HACK HACK: until CoreCLR exists for all the targets, work only with arm64 -->
11-
<!-- armeabi-v7a is wired up elsewhere (workload manifest, Ndk.projitems, CMake presets, ArchToApiLevelNonMono) -->
12-
<!-- but is excluded from the native build until the android-arm CoreCLR runtime pack ships (dotnet/runtime#127225). -->
1310
<AndroidSupportedTargetAotAbis>arm64:x86_64</AndroidSupportedTargetAotAbis>
14-
<AndroidSupportedTargetJitAbis>arm64-v8a:x86_64</AndroidSupportedTargetJitAbis>
11+
<AndroidSupportedTargetJitAbis>armeabi-v7a:arm64-v8a:x86_64</AndroidSupportedTargetJitAbis>
1512
</PropertyGroup>
1613

1714
<Import Project="..\..\Configuration.props" />

0 commit comments

Comments
 (0)