Small review changes.

Author: jpobst

Documentation/guides/AndroidMavenLibrary.md

@@ -21,6 +21,8 @@ This will do two things at build time:
 - Download the Java [artifact](https://central.sonatype.com/artifact/com.squareup.okhttp3/okhttp/4.9.3) with group id `com.squareup.okhttp3`, artifact id `okhttp`, and version `4.9.3` from [Maven Central](https://central.sonatype.com/) to a local cache (if not already cached).
 - Add the cached package to the .NET Android bindings build as an [`<AndroidLibrary>`](https://github.com/xamarin/xamarin-android/blob/main/Documentation/guides/building-apps/build-items.md#androidlibrary).
 
+Note that only the requested Java artifact is added to the .NET Android bindings build. Any artifact dependencies are not added. If the requested artifact has dependencies, they must be fulfilled individually.
+
 ### Options
 
 `<AndroidMavenLibrary>` defaults to using Maven Central, however it should support any Maven repository that does not require authentication.  This can be controlled with the `Repository` attribute.

src/Xamarin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Bindings.Maven.targets

@@ -13,8 +13,8 @@ This file contains MSBuild targets used to enable @(AndroidMavenLibrary) support
 
   <PropertyGroup>
     <!-- Maven cache directory, locations copied from XBD which should be sufficiently battle-tested -->
-    <MavenCacheDirectory Condition="'$(OS)'=='Unix' and '$(MavenCacheDirectory)'==''">$(HOME)\Library\Caches\MavenCacheDirectory\</MavenCacheDirectory>
-    <MavenCacheDirectory Condition="'$(OS)'!='Unix' and '$(MavenCacheDirectory)'==''">$(LocalAppData)\MavenCacheDirectory\</MavenCacheDirectory>
+    <MavenCacheDirectory Condition="'$(OS)'=='Unix' and '$(MavenCacheDirectory)'==''">$(HOME)/Library/Caches/dotnet-android/MavenCacheDirectory/</MavenCacheDirectory>
+    <MavenCacheDirectory Condition="'$(OS)'!='Unix' and '$(MavenCacheDirectory)'==''">$(LocalAppData)\dotnet-android\MavenCacheDirectory\</MavenCacheDirectory>
     <MavenCacheDirectory Condition="'$(MavenCacheDirectory)' != '' and !HasTrailingSlash('$(MavenCacheDirectory)')">$(MavenCacheDirectory)\</MavenCacheDirectory>
   </PropertyGroup>
 

src/Xamarin.Android.Build.Tasks/Utilities/MavenExtensions.cs

@@ -18,6 +18,7 @@ namespace Xamarin.Android.Tasks;
 static class MavenExtensions
 {
 	static readonly char [] separator = [':'];
+	static XmlSerializer pom_serializer = new XmlSerializer (typeof (Project));
 
 	/// <summary>
 	/// Shortcut for !string.IsNullOrWhiteSpace (s)
@@ -27,7 +28,7 @@ static class MavenExtensions
 	// Helps to 'foreach' into a possibly null array
 	public static T [] OrEmpty<T> (this T []? value)
 	{
-		return value ?? Enumerable.Empty<T> ().ToArray ();
+		return value ?? Array.Empty<T> ();
 	}
 
 	public static Artifact? ParseArtifact (string id, string version, TaskLoggingHelper log)
@@ -48,10 +49,8 @@ public static Project ParsePom (string pomFile)
 	{
 		Project result = null;
 
-		var serializer = new XmlSerializer (typeof (Project));
-
 		using (var sr = File.OpenRead (pomFile))
-			result = (Project) serializer.Deserialize (new XmlTextReader (sr) {
+			result = (Project) pom_serializer.Deserialize (new XmlTextReader (sr) {
 				Namespaces = false,
 			});